Date: Mon, 4 Mar 2024 15:43:58 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
	Peter Smith <smithpb2250@gmail.com>,
	shveta malik <shveta.malik@gmail.com>,
	Masahiko Sawada <sawada.mshk@gmail.com>,
	Ajin Cherian <itsajin@gmail.com>,
	Dilip Kumar <dilipbalaut@gmail.com>,
	Nisha Moond <nisha.moond412@gmail.com>,
	"Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Bruce Momjian <bruce@momjian.us>,
	Ashutosh Sharma <ashu.coek88@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Re: Synchronizing slots from primary to standby
Message-ID: <ZeXsPvDpFpsfGorD@ip-10-97-1-34.eu-west-3.compute.internal>
References: <OS0PR01MB5716E281A55E5053DF4976D1945E2@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAHut+PtDo7LRmAQ4CdR7jSscZBvU7O4rsBSGYobSEPuj-93bXw@mail.gmail.com>
 <OS0PR01MB5716B48653125E199A0901D3945D2@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAHut+Psgm2NhzJCi7ZxhpdnuDG+tY34DpnrbXBiAHt1Oa=2Sew@mail.gmail.com>
 <CAA4eK1+KG=u0XJqNFZEYFAXroHvoEJxVM3Q1t-uvut_eNBVLsw@mail.gmail.com>
 <CAHut+PteoyDki-XdygDgoaZJLmasutzRquQepYx0raNs0RSMvg@mail.gmail.com>
 <CAA4eK1Kq0z-wqV5Yo-46CbvMEtqGksPH337cv8H+XafVjzSRkA@mail.gmail.com>
 <CAHut+PtLGLaErYMxNb3HNp3gkRq3-_CA7sOO1TFmPDroAr8n5A@mail.gmail.com>
 <CAA4eK1K3+t0zF=d3YMKMP6KRM4byubhuMPXGCmp1Xufhvsyz6Q@mail.gmail.com>
 <OS0PR01MB5716881EDFAC8682E9219A4E94232@OS0PR01MB5716.jpnprd01.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <OS0PR01MB5716881EDFAC8682E9219A4E94232@OS0PR01MB5716.jpnprd01.prod.outlook.com>
Archived-At: <https://www.postgresql.org/message-id/ZeXsPvDpFpsfGorD%40ip-10-97-1-34.eu-west-3.compute.internal>
Precedence: bulk

Hi,

On Mon, Mar 04, 2024 at 01:28:04PM +0000, Zhijie Hou (Fujitsu) wrote:
> Attach the V105 patch set

Thanks!

Sorry I missed those during the previous review:

1 ===

Commit message: "these functions will block until"

s/block/wait/ ?

2 ===

+        when used with logical failover slots, will block until all

s/block/wait/ ?

It seems those are the 2 remaining "block" that could deserve the proposed
above change.

3 ===

+               invalidated = slot->data.invalidated != RS_INVAL_NONE;
+               inactive = slot->active_pid == 0;

invalidated = (slot->data.invalidated != RS_INVAL_NONE);
inactive = (slot->active_pid == 0);

instead?

I think it's easier to read and it looks like this is the way it's written in
other places (at least the few I checked).

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com