Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 5 Mar 2024 15:31:25 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: pgsql-hackers@lists.postgresql.org, Mats Kindahl <mats@timescale.com>
Subject: Re: Hooking into ExplainOneQuery() complicated by missing
 standard_ExplainOneQuery
Message-ID: <Zea8PbGrxXb8Qhlu@paquier.xyz>
References: <CA+14427V_B4EAoC_o-iYYucRdMSOTfpuH9k-QbexffY1HYJBiA@mail.gmail.com>
 <CAJ7c6TNumEgVKmR+b=r5cfB3pAdxq9eF4+B9QbtCri9tzC5T4Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="pVwmDVI4ByOc2Edy"
Content-Disposition: inline
In-Reply-To: <CAJ7c6TNumEgVKmR+b=r5cfB3pAdxq9eF4+B9QbtCri9tzC5T4Q@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Zea8PbGrxXb8Qhlu%40paquier.xyz>
Precedence: bulk


--pVwmDVI4ByOc2Edy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 04, 2024 at 03:41:16PM +0300, Aleksander Alekseev wrote:
>> I wanted to hook into the EXPLAIN output for queries and add some
>> extra information, but since there is no standard_ExplainOneQuery() I
>> had to copy the code and create my own version.=20
>>
>> Since the pattern with other hooks for a function
>> WhateverFunction() seems to be that there is a
>> standard_WhateverFunction() for each WhateverFunction_hook, I
>> created a patch to follow this pattern for your consideration.

So you've wanted to be able to add some custom information at the end
or the beginning of ExplainState's output buffer, before falling back
to the in-core path.  What was the use case, if I may ask?

>> I was also considering adding a callback so that you can annotate
>> any node with explanatory information that is not a custom scan
>> node. This could be used to propagate and summarize information
>> from custom scan nodes, but I had no immediate use for that so did
>> not add it here. I would still be interested in hearing if you
>> think this is something that would be useful to the community.

That depends.

> I registered the patch on the nearest open CF [1] and marked it as
> RfC. It is a pretty straightforward refactoring.
>=20
> [1]: https://commitfest.postgresql.org/48/4879/

I know that we're in the middle of commit fest 47 while this is in 48,
but I can't really see a reason why we should not do that earlier than
v18.  One point about core is to be flexible for extension code.  So I\
have no objections, others are free to comment.
--
Michael

--pVwmDVI4ByOc2Edy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmXmvD0ACgkQnvQgOdby
QH2N/Q/7BS208ygJFhVwE2KpgKnu/s0/a652WpIlwmPjslqnlSYxkVrEg/yXZslJ
65X0cyKhiq866P4EOKLaFMj244iD1BgEi/pvNLJOJ6ZdK/ymiw8tjof/zeqPMBpZ
94wwF9tmdxcuAUv9RAQ6Z3IpX+2YO7Asz37P6bbhZ2B5LdOsaojGFTJvukTZzmhZ
mKscmEaRKicujhWK3nfIN7KhPSSsKC+bxQUxwFvPtjQUOI/rJVivO4Wu3qYKg0vz
aVTdFyF4hwjdxJFH8FPFQ0C6DjmIIfvfNwiEaGZM/zXJCVPZUe73zTRZgEGi9hoo
DMhs6/YY+eLtWa767IZjM4pfnknAtamA91ZAcUgp0C9/jGyjmlPJniofmKUiBKWw
jmROkIjDdK0rcwjnQjjDiurgeEOVzi2pjyn5p1jWJhv/Jza4FoV/P5FiO259z8KC
GvmgHyrrt91yU5iw2ZKyw+RxREUmV4zAyTVELAOpbKVYSaKPBvMgWeBCnE9922Og
ESHOQISj7EqyMTzt0pcN55XR01M5G753wXyPz0xoA5BRI3QsP+8vJug02DiNZRGS
xOah7zD8GmI06L4A7+DBB2X9BAUoARRCodXpJ/tayPBmVvkxIAjbwlzeehePX/KY
HHLp74favkh7HMolAZkenqPSdSes4cHsKtL+HoC5zRmje1vVJZM=
=ZmdY
-----END PGP SIGNATURE-----

--pVwmDVI4ByOc2Edy--