Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 6 Mar 2024 08:25:16 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Mats Kindahl <mats@timescale.com>
Cc: Aleksander Alekseev <aleksander@timescale.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Hooking into ExplainOneQuery() complicated by missing
 standard_ExplainOneQuery
Message-ID: <Zeep3F-uh8oDpuR3@paquier.xyz>
References: <CA+14427V_B4EAoC_o-iYYucRdMSOTfpuH9k-QbexffY1HYJBiA@mail.gmail.com>
 <CAJ7c6TNumEgVKmR+b=r5cfB3pAdxq9eF4+B9QbtCri9tzC5T4Q@mail.gmail.com>
 <Zea8PbGrxXb8Qhlu@paquier.xyz>
 <CA+14427odXsZ9Wycb2hLv3RmsOdx_vzZdTtiWhaRR1r3SOVupg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="uL8alkBzIrhYi7cA"
Content-Disposition: inline
In-Reply-To: <CA+14427odXsZ9Wycb2hLv3RmsOdx_vzZdTtiWhaRR1r3SOVupg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Zeep3F-uh8oDpuR3%40paquier.xyz>
Precedence: bulk


--uL8alkBzIrhYi7cA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Mar 05, 2024 at 08:21:34AM +0100, Mats Kindahl wrote:
> I realize that a more advanced system is possible to create where you can
> customize the output even more, but in this case I just wanted to add a
> section with some additional information related to plan execution. Also,
> the code in explain.c seems to not be written with extensibility in mind,
> so I did not want to make too big a change here before thinking through how
> this would work.

Sure.

> Just to elaborate: the intention was to allow a section to be added to
> every node in the plan containing information from further down and also
> allow this information to propagate upwards. We happen to have buffer
> information right now, but allowing something similar to be added
> dynamically by extending ExplainNode and passing down a callback to
> standard_ExplainOneQuery.

Or an extra hook at the end of ExplainNode() to be able to append more
information at node level?  Not sure if others would agree with that,
though.
--
Michael

--uL8alkBzIrhYi7cA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmXnqdwACgkQnvQgOdby
QH32wg/9FqEpZPRoEBkgjFE5lUKWOmqj/bL9pTpTuzs7Qa6ZxHs2yOznLr46e77B
aZsrnppbkolVAUmPOizVdqBVxmSVl5K/N00s17LtRMndAuMabrVf9/rnt3HahVFK
J9DIpJwnYwwL/WfCJ64Kv/Q+lJuoTl6pFFEaREQ1FZFQUb+KUxmE/dMesf26LKGq
+mC1klSnW4y92l1skkUreFcBW10NBYpiNgH8z6NT+fJF/aXNyfuunycDIpTRM+GI
Hbjq8CeHqDe0Pur901qmMq8ElFTKpem7Alr8GtwLPC/N8+v7P3j3E+UVT/xh8zI2
yxSPvkB56tnA+oQIK40K56z0mgXNX86ahGLZMoWgdo1t3mykBFP3/dYyXy4M7wgl
IbBGcpeOZokvV9k0xXanqGrDp0ojTxO+idJivZfU7DKilTtv+qCkQhM3TfiWv4bU
TVAE+S9Xw2TMibzL7IXMQvTwGyIHgTMJxImVMvocysdmxeXRN7nGutn2UXo2KXVe
zrJLuwxNz4Cy15jaaS3GT/33fh2D7HgiDK8hfZglMov08jcdUlT4WVjoF//vxNX4
K29OHi4IgoHzlsb9psMEeh9is6hP6VzB6pJftWsXR+Xz0k9ayepkEfIPKqQ3hanc
4o/fRfm38DMCd8J159HiSsKKlmjez17g1NLoxwDAjOdVsHnqhMA=
=xGXY
-----END PGP SIGNATURE-----

--uL8alkBzIrhYi7cA--