Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 7 Mar 2024 07:54:51 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	"Andrey M. Borodin" <x4mmm@yandex-team.ru>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>,
	Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Subject: Re: Injection points: some tools to wait and wake
Message-ID: <Zej0Oyd_FlOjY6Ut@paquier.xyz>
References: <ZeE3GTbamjlN1RrP@paquier.xyz>
 <ZeF7Pct9eJaN6z5N@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZeUngiC5Wzi_LiYH@paquier.xyz>
 <CAGECzQQB0YwoCo8za5DSs1zNyMPHLiz5jwOi-xRhe5517qNugA@mail.gmail.com>
 <ZeVbugAp1eXCvllA@paquier.xyz>
 <CAGECzQQ-rEPem3=s-esDo=tvLsq2Wt1-NrwroyUuZpYfby2nDg@mail.gmail.com>
 <ZeZJ0yv5kmLlYAAN@paquier.xyz>
 <CAGECzQSfAeYJKQpU6Q-DU8s1TavP11rA6cmei-PSj2MpVU2hGQ@mail.gmail.com>
 <ZegKgDBhJbd4FxIJ@paquier.xyz>
 <CAGECzQRO7noJQHsXGUUTCgmyJE-XXrV_B6dsBacy2UA=ixgBjQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="TL2+O5Ku4AIzN6RK"
Content-Disposition: inline
In-Reply-To: 
 <CAGECzQRO7noJQHsXGUUTCgmyJE-XXrV_B6dsBacy2UA=ixgBjQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Zej0Oyd_FlOjY6Ut%40paquier.xyz>
Precedence: bulk


--TL2+O5Ku4AIzN6RK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 06, 2024 at 10:19:41AM +0100, Jelte Fennema-Nio wrote:
> What I mainly meant is that anything in src/test/modules is not even
> close to somewhat useful for other people to use. They are really just
> very specific tests that need to be written in C. Afaict all those
> modules are not even used by tests outside of their own module. But
> these functions are helper functions, to be used by other tests. And
> limiting the users of those helper functions to just be in-core
> Postgres code seems a bit annoying. I feel like these functions are
> more akin to the pgregress/isolationtester binaries in their usage,
> than akin to other modules in src/test/modules.

Perhaps.  I think that we're still in the discovery phase for this
stuff, and more people should get used to it first (this will take
some time and everybody is busy with their own stuff for the last
commit fest).  At least it does not seem good to rush any decisions at
this stage.

>> FWIW, it would be really annoying to have documentation
>> requirements, actually, because that increases maintenance and I'm not
>> sure it's a good idea to add a module maintenance on top of what could
>> require more facility in the module to implement a test for a bug fix.
>=20
> Quite a few contrib modules have very limited documentation. I think
> it would be fine for this as well.

I'd argue that we should try to improve the existing documentation
rather that use that as an argument to add more modules with limited
documentation ;)

> Ugh... Sorry... I didn't realize that it needed a dedicated configure
> flag. When providing that flag it indeed installs the expected files.
> I guess that rules out testing against PGDG packages, because those
> packages almost certainly wouldn't specify this flag.

The CI enables the switch, and I've updated all my buildfarm members
to use it.  In terms of coverage, that's already quite good.
--
Michael

--TL2+O5Ku4AIzN6RK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmXo9DsACgkQnvQgOdby
QH2pNQ//SZNRSLgKfxraytEuuFuB7mJ0UK6CUGHniI/NRt655BMsn7NMesNXB2a7
sRhwmCAlfg5tMS27SoDqgX+4fKi3ui1b/WzkXzpk6tsAdx+W1N9sg1bLMsG5Li12
iF3aVfhEkKIB0YsblAEXV7qzIn+o4OUZ/dUjv5UNO+f5wviQjwTWUCjR7Kp1Y9l+
YhZC/mcWtxWGOKqjaGZUAhBPekULBnT8WrbYOdl7ttz1YX+hEvk4rObR5yDQHJbC
x5P/UmJ704HKFgswIlj+SGN2YEC1d2wPd0BiCF8eH9ubcIl8vwLUcqv5M+WwbVyS
LoHk9sB4SEGy1w/KK+YWblCBFtWkPnqYGPboyhV3p4sC7IN6SrqxweeDSbkBE1+v
AIr6Iv8dqMrCdEqh8YnECmKmG5xbIdTfB8MhYEcy4kqtEXo+ajhDN5/uY3AFB+Tz
IRRSYozLaqBLMapP7GJSQDWA3C9NVakT8m8/aATzwHXCrzdGvxZ1OLzoSiOUEu+c
29O9sPOlU/u6RYjffCbD0x0bghNFMJd4hOzTm9gsmnT+6QApkihLqXtzOOtUelvI
jlYWBpCiPyQStUbPb2KVLhJSxFUIfe4qP85zXr+pclS8hL6G4J/3SElo38uot1vH
PsjKksiaBEQU7EkwhG7+vSwwWrU4g4iI01Z7bMjphwm09yZt8Ew=
=IQfj
-----END PGP SIGNATURE-----

--TL2+O5Ku4AIzN6RK--