public inbox for [email protected]help / color / mirror / Atom feed
[PATCH v17 03/10] Add tests on pg_ls_dir before changing it 2+ messages / 2 participants [nested] [flat]
* [PATCH v17 03/10] Add tests on pg_ls_dir before changing it @ 2020-03-17 18:16 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: Justin Pryzby @ 2020-03-17 18:16 UTC (permalink / raw) --- src/test/regress/expected/misc_functions.out | 18 ++++++++++++++++++ src/test/regress/sql/misc_functions.sql | 5 +++++ 2 files changed, 23 insertions(+) diff --git a/src/test/regress/expected/misc_functions.out b/src/test/regress/expected/misc_functions.out index d3acb98d04..2e87c548eb 100644 --- a/src/test/regress/expected/misc_functions.out +++ b/src/test/regress/expected/misc_functions.out @@ -201,6 +201,24 @@ select count(*) > 0 from t (1 row) +select * from (select pg_ls_dir('.', false, true) as name) as ls where ls.name='.'; -- include_dot_dirs=true + name +------ + . +(1 row) + +select * from (select pg_ls_dir('.', false, false) as name) as ls where ls.name='.'; -- include_dot_dirs=false + name +------ +(0 rows) + +select pg_ls_dir('does not exist', true, false); -- ok with missingok=true + pg_ls_dir +----------- +(0 rows) + +select pg_ls_dir('does not exist'); -- fails with missingok=false +ERROR: could not open directory "does not exist": No such file or directory -- -- Test adding a support function to a subject function -- diff --git a/src/test/regress/sql/misc_functions.sql b/src/test/regress/sql/misc_functions.sql index 094e8f8296..f6857ad177 100644 --- a/src/test/regress/sql/misc_functions.sql +++ b/src/test/regress/sql/misc_functions.sql @@ -60,6 +60,11 @@ select count(*) > 0 from where spcname = 'pg_default') pts join pg_database db on pts.pts = db.oid; +select * from (select pg_ls_dir('.', false, true) as name) as ls where ls.name='.'; -- include_dot_dirs=true +select * from (select pg_ls_dir('.', false, false) as name) as ls where ls.name='.'; -- include_dot_dirs=false +select pg_ls_dir('does not exist', true, false); -- ok with missingok=true +select pg_ls_dir('does not exist'); -- fails with missingok=false + -- -- Test adding a support function to a subject function -- -- 2.17.0 --4LFBTxd4L5NLO6ly Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v17-0004-Add-pg_ls_dir_metadata-to-list-a-dir-with-file-m.patch" ^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Provide a pg_truncate_freespacemap function @ 2024-03-06 19:28 Stephen Frost <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: Stephen Frost @ 2024-03-06 19:28 UTC (permalink / raw) To: Ronan Dunklau <[email protected]>; +Cc: [email protected] Greetings, * Ronan Dunklau ([email protected]) wrote: > As we are currently experiencing a FSM corruption issue [1], we need to > rebuild FSM when we detect it. Ideally, we'd figure out a way to pick up on this and address it without the user needing to intervene, however ... > I noticed we have something to truncate a visibility map, but nothing for the > freespace map, so I propose the attached (liberally copied from the VM > counterpart) to allow to truncate a FSM without incurring downtime, as > currently our only options are to either VACUUM FULL the table or stop the > cluster and remove the FSM manually. I agree that this would generally be a useful thing to have. > Does that seem correct ? Definitely needs to have a 'REVOKE ALL ON FUNCTION' at the end of the upgrade script, similar to what you'll find at the bottom of pg_visibility--1.1.sql in the tree today, otherwise anyone could run it. Beyond that, I'd suggest a function-level comment above the definition of the function itself (which is where we tend to put those- not at the point where we declare the function). Thanks! Stephen Attachments: [application/pgp-signature] signature.asc (833B, ../../ZejD7P+i2ZPDw8O%[email protected]/2-signature.asc) download ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-03-06 19:28 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-03-17 18:16 [PATCH v17 03/10] Add tests on pg_ls_dir before changing it Justin Pryzby <[email protected]> 2024-03-06 19:28 Re: Provide a pg_truncate_freespacemap function Stephen Frost <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox