public inbox for [email protected]  
help / color / mirror / Atom feed
From: Michael Paquier <[email protected]>
To: Bharath Rupireddy <[email protected]>
Cc: torikoshia <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: [email protected]
Cc: Pgsql Hackers <[email protected]>
Cc: Alexander Korotkov <[email protected]>
Subject: Re: Add new error_action COPY ON_ERROR "log"
Date: Wed, 13 Mar 2024 14:39:06 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALj2ACW=QJcmqP4VWNAzBmgaG5f5bSjU_hAGzS2NfwRJdy2cJw@mail.gmail.com>
References: <[email protected]>
	<CALj2ACW1XUhFbvO9BO8arHGxQTHyr5cy1_csZAt6Rphvx8q1mg@mail.gmail.com>
	<[email protected]>
	<CALj2ACUi9R5nWhjyONN9wW1xMwV4VdZ3zOu1Q1rQYSFjn-70qg@mail.gmail.com>
	<[email protected]>
	<CALj2ACUZkGMTz10kC3+LcxjGz6NMN1URTn8+K=k_rtm7=z8zSA@mail.gmail.com>
	<[email protected]>
	<CALj2ACW8c8zO0__+9jP1zZ0ZfAj_gcOUN336nD4NW4pPTc1YQg@mail.gmail.com>
	<[email protected]>
	<CALj2ACW=QJcmqP4VWNAzBmgaG5f5bSjU_hAGzS2NfwRJdy2cJw@mail.gmail.com>

On Wed, Mar 13, 2024 at 08:08:42AM +0530, Bharath Rupireddy wrote:
> On Wed, Mar 13, 2024 at 5:16 AM Michael Paquier <[email protected]> wrote:
>> The attached 0003 is what I had in mind:
>> - Simplification of the LOG generated with quotes applied around the
>> column name, don't see much need to add the relation name, either, for
>> consistency and because the knowledge is known in the query.
>> - A few more tests.
>> - Some doc changes.
> 
> LGMT. So, I've merged those changes into 0001 and 0002.

I've applied the extra tests for now, as this was really confusing.

Hmm.  This NOTICE is really bugging me.  It is true that the clients
would get more information, but the information is duplicated on the
server side because the error context provides the same information as
the NOTICE itself:
NOTICE:  data type incompatibility at line 1 for column "a"
CONTEXT:  COPY aa, line 1, column a: "a"
STATEMENT:  copy aa from stdin with (on_error ignore, log_verbosity verbose); 
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
  download

view thread (8+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Add new error_action COPY ON_ERROR "log"
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox