Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 19 Mar 2024 08:59:30 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Andres Freund <andres@anarazel.de>,
	"Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Autogenerate some wait events code and documentation
Message-ID: <ZfjVYtrbRZSV2FRz@paquier.xyz>
References: <ZOxVHQwEC/9X/p/z@paquier.xyz>
 <202403180924.rqdpwo4b3bd5@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ah5r4ICclNTp/aS/"
Content-Disposition: inline
In-Reply-To: <202403180924.rqdpwo4b3bd5@alvherre.pgsql>
Archived-At: <https://www.postgresql.org/message-id/ZfjVYtrbRZSV2FRz%40paquier.xyz>
Precedence: bulk


--ah5r4ICclNTp/aS/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 18, 2024 at 10:24:00AM +0100, Alvaro Herrera wrote:
> FTR I had a rather unpleasant time last week upon finding a wait event
> named PgSleep.  If you grep for that, there are no matches at all; and I
> spent ten minutes (for real) trying to figure out where that was coming
> from, until I remembered this thread.
>=20
> Now you have to guess that not only random lowercasing is happening, but
> also underscore removal.  This is not a good developer experience and I
> think we should rethink this choice.  It would be infinitely more
> usable, and not one bit more difficult, to make these lines be
>=20
> WAIT_EVENT_FOO_BAR	FooBar	"Waiting on Foo Bar."
>=20
> then there is no guessing involved.

This has already gone through a couple of adjustments in 59cbf60c0f2b
and 183a60a628fe.  The latter has led to the elimination of one column
in the txt file, as a reply to the same kind of comments about the
format of this file:
https://www.postgresql.org/message-id/20230705215939.ulnfbr4zavb2x7ri%40awo=
rk3.anarazel.de

FWIW, I still like better what we have currently, where it is possible
to grep the enum values in the source code.
--
Michael

--ah5r4ICclNTp/aS/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmX41WIACgkQnvQgOdby
QH0aexAAhqVl8o2Loej5GQJr/b48cAUkuZMBMm8+RDjfHx3ZlXCg8zSh8EysVZy6
F6hWmk+gbbv5huTwJwFxExOhV7Taavpup3r5VNuAbWjPE+9txbFGSTSGlaRAG8my
vo4/mj0qDqUO6nzuH5IXNdeMipm9i2zmXeiVTA87RAW6d42IicJvTFRJ1Bt+oEjP
ejQYTfx+E04UF2n9GevMdnDt+jrM2NPYX9txysNe8eNR0HsHzNwLkSMYrsQOO1i3
WjzqTBu5OZe+fYoNRHtI5r/P4LL+Dc+BEiENH7X3+3Zwmk9/rO5vwBN9W+le5N+K
l6P9rUzmxHEXPr7reWCutbpKcj6sGDfzHNiSeC0JDT7ggqG80Ar7iJ2I0rBRuNw3
cTBbtscVWhHCWjieDJW1M1sc2txKt0tmGXyFicKkL1RppvgFLKYg0m6gQ2wzdrsF
FSJMp0klmQUJpKPCg5wFK9q0Q3ECpsxx1uuPoOP8rC4IbdEdW3HGTof0CejLFWQU
8q6Ky1Z4GrVRvEVDKUcMslRRHYS8b/4zfSDUQZF+Mg0/lWARTJBGO0xu/yHzsSfV
slN8IosUXc9r8idYpZLCWfh9UTAMvepHpfhZV1TNQRmMddt0rSGoTe8pNu4OCZpC
v898kvjo0Y6Y/K6Kq8QWafcbNnWnvuBgyKwtGj0fuO2+VQbXzTY=
=DizL
-----END PGP SIGNATURE-----

--ah5r4ICclNTp/aS/--