Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 19 Mar 2024 09:59:35 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Noah Misch <noah@leadboat.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Autogenerate some wait events code and documentation
Message-ID: <Zfjjd-sqqBNTXiIR@paquier.xyz>
References: <ZGWrTn//v+WAqMpN@paquier.xyz>
 <ZKJxZrnFTxoCx8a5@paquier.xyz>
 <ZKJ0tzXSH1LyqI9V@paquier.xyz>
 <0b3cdac7-f078-61a6-76e0-99db7aae78ce@gmail.com>
 <ZKTN//NfDeP1egLW@paquier.xyz>
 <20240317183114.16@rfd.leadboat.com>
 <Zfd2gKf00dfxwi4d@paquier.xyz>
 <ZfgDrC5lW99sI8MM@ip-10-97-1-34.eu-west-3.compute.internal>
 <20240318154934.10.nmisch@google.com>
 <ZfiAbt8u+XW+Raps@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="RVkrCdGxhX9+pT3s"
Content-Disposition: inline
In-Reply-To: <ZfiAbt8u+XW+Raps@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: 
 <https://www.postgresql.org/message-id/Zfjjd-sqqBNTXiIR%40paquier.xyz>
Precedence: bulk


--RVkrCdGxhX9+pT3s
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Mar 18, 2024 at 05:57:02PM +0000, Bertrand Drouvot wrote:
> Thanks for looking at it!
> Oh right, the comment is wrong, re-worded in v2 attached.

I've added a couple of fake events in my txt file, and this results in
an ordering of the wait events in the docs while the backpatched wait
events are added at the end of the enums, based on their order in the
txt file.

 # When adding a new wait event, make sure it is placed in the appropriate
-# ClassName section.
+# ClassName section. If the wait event is backpatched from master to a version
+# >= 17 then put it under a "Backpatch:" delimiter at the end of the related
+# ClassName section (on the non master branches) or at its natural position on
+# the master branch.
+# Ensure that the backpatch regions are always empty on the master branch.

I'd recommend to not mention a version number at all, as this would
need a manual refresh each time a new stable branch is forked.

Your solution is simpler than what I finished in mind when looking at
the code yesterday, with the addition of a second array that's pushed
to be at the end of the "sorted" lines ordered by the second column.
That does the job.

(Note that I'll go silent for some time; I'll handle this thread when
I get back as this is not urgent.)
--
Michael

--RVkrCdGxhX9+pT3s
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmX443cACgkQnvQgOdby
QH0+VA/8DTmxcWx9auHMO/fPfLPFtKct1/ahULksyn2CtVyVX8i0xOKopP6zcZbH
Q+9Ils2Q8anONkx+m2o9pDIeJLSbjSM+7pUqZzQpVPlTnrkGCtS7llmViqEQ2gga
wIfi+mW7GE5McYT0W8G3h0u5HbqD/ktErKVpqZEgnTiRWq897vrAZ05lU2GsEuRr
S6kuosYfSoveJELKTMl/btEg4N5O+VTI94Tskwe9Xie/5rACBt/rgYfGHi/fX3fh
K/91uEwnLlgrLgbhHSwMLx+guOZ5Z+Ii0NXBid3jIMStCGFUlmRV6Jr8zgSUtHO4
c/msmJcBS3pdHztpVR14+9LGeJdOtWTra5YAMhEH/ULdewW1Dkaky63JOqSPHMo1
AZFLSIhI4cH4gJXLooWYTCsn76n26BU4llK6LWog5lB+K5TmKyNGH/wVOgwFVqwP
EoZU+dcQ6SjI1RCh/HXs4FyXgbqgbFN85i4LIgOMoKALMWjxO5ZqY7sOdYeOBgL8
VofWnG/WlMZWdYw7LA258eyOLVGeEY1bf9FScsJE/Ac2q051Sid1FYLg98e754cn
EMkLJ8jiNNiRbbVAkAgeuK9QQV8j14IXPrRM8t3JyGMA8ykNzatJok7Ke1ix2hOr
hBDKwbJsuyAQpjmIEJ39P8prYpndKWWjsFJGZ6/MwiicHu9LHx0=
=ZSsd
-----END PGP SIGNATURE-----

--RVkrCdGxhX9+pT3s--