public inbox for [email protected]
help / color / mirror / Atom feedFrom: Bruce Momjian <[email protected]>
To: [email protected] <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Cc: Alexander Pyhalov <[email protected]>
Cc: Stephen Frost <[email protected]>
Cc: Finnerty, Jim <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: Julien Rouhaud <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: vignesh C <[email protected]>
Subject: Re: Partial aggregates pushdown
Date: Thu, 21 Mar 2024 18:01:00 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <TYAPR01MB55148E058FF041AE614BCF3495322@TYAPR01MB5514.jpnprd01.prod.outlook.com>
References: <CA+TgmoYCrtOvk2f32qQKZV=jNL35tandf2A2Dp_2F5ASuiG1BA@mail.gmail.com>
<TYAPR01MB5514C939F39F97BC171F58FD958BA@TYAPR01MB5514.jpnprd01.prod.outlook.com>
<CALDaNm0S5fb_8o+TtR8bXf3zOpqabOBLy0EJ3+oVzHH_dzpXvw@mail.gmail.com>
<TYAPR01MB5514F0CBD9CD4F84A261198195562@TYAPR01MB5514.jpnprd01.prod.outlook.com>
<[email protected]>
<TYAPR01MB55141D18188AC86ADCE35FCB952F2@TYAPR01MB5514.jpnprd01.prod.outlook.com>
<[email protected]>
<[email protected]>
<[email protected]>
<TYAPR01MB55148E058FF041AE614BCF3495322@TYAPR01MB5514.jpnprd01.prod.outlook.com>
On Thu, Mar 21, 2024 at 11:37:50AM +0000, [email protected] wrote:
> Hi. Mr.Momjian, Mr.Lane, Mr.Haas, hackers.
>
> I apologize for any misunderstanding regarding the context of the attached patch and
> the points on which I requested a review. Could you please allow me to clarify?
>
> In the review around early December 2023, I received the following three issues pointed out by Mr.Haas[1].
> 1. Transmitting state value safely between machines
> 2. Making the patch clearer by adding SQL keywords
> 3. Fixing the behavior when the HAVING clause is present
>
> In the email sent on February 22, 2024[2], I provided an update on the progress made in addressing these issues.
> Regarding issue 1, I have only provided a proposed solution in the email and have not started the programming.
> Therefore, the latest patch is not in a commit-ready state. As mentioned later, we have also temporarily reverted the changes made to the documentation.
> Before proceeding with the programming, I would like to discuss the proposed solution with the community and seek consensus.
> If it is necessary to have source code in order to discuss, I can create a simple prototype so that I can receive your feedback.
> Would you be able to provide your opinions on it?
>
> Regarding issue 2., I have confirmed that creating a prototype allows us to address the issue and clear the patch.
> In this prototype creation, the main purpose was to verify if the patch can be cleared and significant revisions were made to the previous version.
> Therefore, I have removed all the document differences.
> I have submitted a patch [3] that includes the fixes for issue 3. to the patch that was posted in [2].
> Regarding the proposed solution for issue 1, unlike the patch posted in [3],
> we have a policy of not performing partial aggregation pushdown if we cannot guarantee compatibility and safety.
> The latest patch in [3] is a POC patch. The patch that Mr. Momjian reviewed is this.
> If user-facing documentation is needed for this POC patch, it can be added.
>
> I apologize for the lack of explanation regarding this positioning, which may have caused misunderstandings regarding the patch posted in [3].
That makes sense. Let's get you answers to those questions first before
you continue.
--
Bruce Momjian <[email protected]> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
view thread (5+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Partial aggregates pushdown
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox