Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rsX6w-007gb9-8N for pgsql-hackers@arkaria.postgresql.org; Fri, 05 Apr 2024 00:07:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rsX6v-00EGYC-FK for pgsql-hackers@arkaria.postgresql.org; Fri, 05 Apr 2024 00:07:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rsX6t-00EGXv-Uf for pgsql-hackers@lists.postgresql.org; Fri, 05 Apr 2024 00:07:13 +0000 Received: from wfout6-smtp.messagingengine.com ([64.147.123.149]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rsX6q-000gxp-0b for pgsql-hackers@lists.postgresql.org; Fri, 05 Apr 2024 00:07:11 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.west.internal (Postfix) with ESMTP id 7D91E1C000F8; Thu, 4 Apr 2024 20:07:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 04 Apr 2024 20:07:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1712275624; x=1712362024; bh=Xhc5RhRVks 4h/p7GJjxaUCj8JYvo5N/2PxZpOHRnCy4=; b=gzKMptgGwJ44u5Gse16nwbPPQa Iip8R6LWSa2N440o2icPg88s0+kCyjuVAat2QdfjFMvtqMo5elwQu/y0g4hoEyc2 V5ce5AAabSCqQr1lJ/bQPtTybduVRhucSxp8xn5h4JmObYfzyEIF8EWCfJDc3r3O 9LY4hWUKvuhgLBph5rmflcD+9rLymj3/KCztQn0i6pZKjOjjpNPcfI17woUXurfV jfCn54UVM8jZ9dzqIh87JSs+fvIac2CRxxZv/4Vjo9Awa2OUnCmQXH/p3du9302i aRrg+GeblPz1Zt8aS1bR8KWSUKSRQtFCXh6D7v/oRIkHCAVtV37Pq1EFoI/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1712275624; x=1712362024; bh=Xhc5RhRVks4h/p7GJjxaUCj8JYvo 5N/2PxZpOHRnCy4=; b=GUWSdgX92U6JQs6Eixek1ssBtrYqpEhY58C9S9NAEQB2 S9kGSXpDUSUG3jteaODIAEi+tmP0sTgJ/1Qacs7vAWC/riJMD253QodZtaDBoV15 FmwzpNMyLk00VpU0hhwZVLdSHQfB2zyeOvmc6FIeBpZAsi+DkXSiZP7+2iLp5oZe 0hYwxTz7BOF9Zw2ad62Q/E86NXR3TtCb0bLEBQ0WEQZbnx9pcKWB4Va/xRFR3Q2i wNPzNN5G08q/AlxbGxeErVqiDqxkUh48CHLv1DIJ6ogQM2Qk7UG+9jkh+3zPgESb grO1dApzR88WAZCul8haqGnOQAK4V3Q48+AHuW3v7g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudefledgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 4 Apr 2024 20:07:01 -0400 (EDT) Date: Fri, 5 Apr 2024 09:06:44 +0900 From: Michael Paquier To: Bertrand Drouvot Cc: Noah Misch , PostgreSQL Hackers Subject: Re: Autogenerate some wait events code and documentation Message-ID: References: <20240318154934.10.nmisch@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="od8Q+6/v7KARAqCs" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --od8Q+6/v7KARAqCs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 04, 2024 at 11:56:36AM +0000, Bertrand Drouvot wrote: > On Thu, Apr 04, 2024 at 07:14:47PM +0900, Michael Paquier wrote: >> I'd add a "as -this section- has its own C code", for clarity. This >> just looked a bit strange here. >=20 > Sounds good, done that way in v5 attached. If there's a better suggestion than "ABI_compatibility" as keyword for this part of the file, this could always be changed later. For now, I've applied what you have here after tweaking a bit more the comments. -- Michael --od8Q+6/v7KARAqCs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmYPQJQACgkQnvQgOdby QH1UbRAAk/0A9wqgXTR9f3QmwqDx8VDnV5M29lEEGvY5YzCmXQq1HCZDo606N+/q ILDQUKvNJcLyXXBUInd8hzFaVV+yxDvyLySkkvJVtKoJO1bQAZNZRYSrDraS/h4L FmnTO/hiBJloV3Zl5fwRpAeh4f3a8P0EUGIIcftULZEWUpJlrbaFtpDh6aX54LJA eXoFRk20pxeiLO2aVXj2YJHB0sC5LtKBBk4C6vx73rzJZ28DO/H5+w+ueimgtx3o mw9RJ6NM50hYLAVOWDNuCvYVIVNfCld8XajzllOTUJCd7FkVDA7grFr0jw3SKdNQ vczSo18OoIafLMxuKPQaumP7cxpGTbPjRaQUkgQpqOiPKa1sObnq7YvNvGkSnMpP OWWcyh3Far05PxQSHNwUA71o2JoJnDfmRC89pZ5Gb6kzUhA8UDBDhV3UBBz4HZZy KOXst790E/LkOEJp5+0OlrBZAuCqbAqmBkxfL+5ACFBgeVOgMbdHlc1Iupt2GYG3 J45uW4qTT5xZsVKYZqXsmsHfcxc4PdZaX/b5g/8T27Od8/sBuq/hAMa587BEUAg8 ehcpLZkpkamhQnV6SvlTuQw9dV1QmG0s7vi1sf59oaXsxO3I6kYwLYZF8guAA9xH uKLAj63r6aFmcVeVo56ws5E8YLSXZxyvRQ4dMt4CdjWoEFAO6h0= =bWNu -----END PGP SIGNATURE----- --od8Q+6/v7KARAqCs--