Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 17 Apr 2024 17:13:02 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Justin Pryzby <pryzby@telsasoft.com>,
	Alexander Lakhin <exclusion@gmail.com>,
	Peter Eisentraut <peter@eisentraut.org>,
	Soumyadeep Chakraborty <soumyadeep2007@gmail.com>,
	Zhihong Yu <zyu@yugabyte.com>, pgsql-hackers@postgresql.org,
	Ashwin Agrawal <ashwinstar@gmail.com>, vanjared@vmware.com
Subject: Re: ALTER TABLE SET ACCESS METHOD on partitioned tables
Message-ID: <Zh-Ejsvm9YYZtJtS@paquier.xyz>
References: <202404170740.dv4jwhwvdieb@alvherre.pgsql>
 <202404170750.3672wigvldoq@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Ci6kYGa4r0+gdvIg"
Content-Disposition: inline
In-Reply-To: <202404170750.3672wigvldoq@alvherre.pgsql>
Archived-At: <https://www.postgresql.org/message-id/Zh-Ejsvm9YYZtJtS%40paquier.xyz>
Precedence: bulk


--Ci6kYGa4r0+gdvIg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Apr 17, 2024 at 09:50:02AM +0200, Alvaro Herrera wrote:
> I think it's easy enough to add a "bool ispartitioned" to TableInfo and
> use an ALTER TABLE or rely on the GUC depending on that -- seems easy
> enough.

Yeah, that would be easy enough to track but I was wondering about
adding the relkind instead.  Still, one thing that I found confusing
is the dump generated in this case, as it would mix the SET and the
ALTER TABLE commands so one reading the dumps may wonder why the SET
has no effect for a CREATE TABLE PARTITION OF without USING.  Perhaps
that's fine and I just worry too much ;)

The extra ALTER commands need to be generated after the object
definitions, so we'd need a new subroutine similar to
_selectTableAccessMethod() like a _selectTableAccessMethodNoStorage().
Or grouping both together is just simpler?
--
Michael

--Ci6kYGa4r0+gdvIg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmYfhI4ACgkQnvQgOdby
QH3Kjg//Yq/Jtcvb5LnKNt7m/Kz44SCbD7EUE6pb+1mO0cYLuNF5R9YSBVE0F522
yOsTKWXiL157idh6rLJvvHmK8q4tIdddQyyO0mA7qMMDjF7XuYmrPI1qsDC1cGd+
OJdR4UUzCsDFRbuf+YJFe9j1WFEyC5DOjC3aZt5ltV4ZpdpHoI0l+9txrOdsGG3m
amw05cwD/iipA6KrFdpbTsSZQmGcy5jHBwOuJvqHoWi0cRvt9CJ03DIrBGQ/8uyg
V2H3QAHltO94Sg136fUpmrzAI81ZuYjzTdZCBhpcvm9LHAccPiPEEQpBVCjwlNAF
7sqlb8izxb3ZJxDu/Mwj5u5QZAcm3DXmI6usiE8XFDw80WuSbBOwi+QiWyxDIi7A
lQAu20US+StzYl0s9V61L3yauXGe4p+YT+qtJjiUdmistgLOJQTgGJnSG+udzSZA
M/DGSKmE60ZwOxOTLZEgGASmQtcdfhyiRyC4fWDUqrDF7CMvdELq+NoKIMNOAvLI
dG42pZ0qRiUOK1ksqzZz/xCQ9HDnjVdkqKa/jFutsAT2I/m71zBPXYGdpMc+lf1C
W1OA3uddKgrINFUrYqe0QPIHMRFcYp2mV+Kr3yHiMjM77RY4HE+wOuAwNrmhGljz
8eYd/0sQvoPkjeoBdHkSo/+HRjSywlSkoUn174pv6DPwzGbx0zk=
=4Cnl
-----END PGP SIGNATURE-----

--Ci6kYGa4r0+gdvIg--