Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 10 Apr 2024 08:50:56 +0900
From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgmasters.net>
Cc: "Andrey M. Borodin" <x4mmm@yandex-team.ru>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Stefan Fercot <stefan.fercot@protonmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: post-freeze damage control
Message-ID: <ZhXUYBXTWvF4OaPm@paquier.xyz>
References: <202404091545.7zont3umry74@alvherre.pgsql>
 <4D31BF67-4138-41DC-831D-4BCE0466A59F@yandex-team.ru>
 <f2e7f916-b32f-48ac-8200-7a803a241b5e@pgmasters.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="rbw5VSo6aBQAd0Pm"
Content-Disposition: inline
In-Reply-To: <f2e7f916-b32f-48ac-8200-7a803a241b5e@pgmasters.net>
Archived-At: <https://www.postgresql.org/message-id/ZhXUYBXTWvF4OaPm%40paquier.xyz>
Precedence: bulk


--rbw5VSo6aBQAd0Pm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Apr 10, 2024 at 09:29:38AM +1000, David Steele wrote:
> Even so, only keeping WAL for the last backup is a dangerous move in any
> case. Lots of things can happen to a backup (other than bugs in the
> software) so keeping WAL back to the last full (or for all backups) is
> always an excellent idea.

Yeah, that's an excellent practive, but is why I'm less worried for
this feature.  The docs at [1] caution about "not to remove earlier
backups if they might be needed when restoring later incremental
backups".  Like Alvaro said, should we insist a bit more about the WAL
retention part in this section of the docs, down to the last full
backup?

[1]: https://www.postgresql.org/docs/devel/continuous-archiving.html#BACKUP-INCREMENTAL-BACKUP
--
Michael

--rbw5VSo6aBQAd0Pm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmYV1GAACgkQnvQgOdby
QH0ilA/9EVVV19dfHbDnUduzTTG80kgWVE3MO7xf064OVUzZbqsHS8PSLMS/TXGG
ia2Fe677NZb8ImzRmST3tAxg1FWIe3Q8Uh+7AIX/gYXYNdHT6qb8euuDQVLgpnC8
QW9oKvJDMvzuhDY0cULGhty4pl6CITOY2vXRCPKTY1V6JGKL1M3tOFnEwDju6mU1
kn+5Xpo4BucC7BZRvR6je/be5ZI8b3ZrJjQPw3Yl4WrqtEIrl7GmtZdDL6brUF00
oDtlh0HrNtjlIf9QYDqSvO9Wp78Ub+9KXlL6Yauu+ylrTi+uDpSpoe8pkIRq9QbZ
sDb0H7qtRiP9pk7bB6xScAUQAUnRdqhuYm91DRSat1cS/WqEHeFhoK39iUUSXEKN
cbG2gjQG9hD11ZfAG3GL+nDhAVQ5yLZtxp961BeoNuuUbalagnNvQ7VSXq8hXsuM
IqBDG5/vxFqJSWckX62qUSMcC80+oMNFxjDDucRfInUo/9ZC0QutcJR86E4fTegz
yre4YlEYEKQEFXvOgVvmp2opbTpgT6gT04120DtlSOn7pMO40EA8ln0uNSoRvIZj
JK57WL3Kp2Lc+9c5wBv2hV/b2xnRW4iStsbeDGkPw/VcKcbVp4a92K1+xHSXEmuL
zYhfOBFzpAzDH1+4+ycQDFAnNAGGA77Py2R9kFklVgpaLDiIUDI=
=pZhe
-----END PGP SIGNATURE-----

--rbw5VSo6aBQAd0Pm--