Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 29 Apr 2024 14:25:10 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Richard Guo <guofenglinux@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: A failure in prepared_xacts test
Message-ID: <Zi8vNgPIaeUP5-iM@paquier.xyz>
References: <CAMbWs4-mWCGbbE_bne5=AfqjYGDaUZmjCw2+soLjrdNA0xUDFw@mail.gmail.com>
 <Zi8pC2WkIL56cHmj@paquier.xyz>
 <1068977.1714367460@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="QPLhHumC/zyqoLsF"
Content-Disposition: inline
In-Reply-To: <1068977.1714367460@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/Zi8vNgPIaeUP5-iM%40paquier.xyz>
Precedence: bulk


--QPLhHumC/zyqoLsF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Apr 29, 2024 at 01:11:00AM -0400, Tom Lane wrote:
> Up to now, we've only worried about whether tests running in parallel
> within a single test suite can interact.  It's quite scary to think
> that the meson setup has expanded the possibility of interactions
> to our entire source tree.  Maybe that was a bad idea and we should
> fix the meson infrastructure to not do that.  I fear that otherwise,
> we'll get bit regularly by very-low-probability bugs of this kind.

I don't disagree with your point, still I'm not sure that this can be
made entirely bullet-proof.  Anyway, I think that we should still
improve this test and make it more robust for parallel operations:
installcheck fails equally on HEAD if there is a prepared transaction
on the backend where the tests run, and that seems like a bad idea to
me to rely on cluster-wide scans for what should be a "local" test.
--
Michael

--QPLhHumC/zyqoLsF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmYvLzYACgkQnvQgOdby
QH1CPBAAjcLln0NU4rp2HRpQldQ+ieOP3Lk0HPBf1PmeTN8X1L+qMkoDVDNgMNOG
nJ3omRpspGxsoVucGDzrlmCQ5NWvd2XZQtHxfL6UqmUWr+aob4bxiKfggMNLakF3
BVjMQ7rcdruVE5HCyFinVoTcLycLBQiAwF9YIY5reQG3Fru+YW1alLieQZ2I5Jy9
w5TzfffxrAxI7pIhFcpZbuBhmKlNxIjNco6CD1UMxdDOIUPC/syk5uMKHC87WmvH
1FeBob0fTWhngRHWu2zdk1u9hc7UJUr7pcbf21M0MpeQSaE2kmlm9ayNjjadJe2S
IFlglPZriSehCruFIY+XuB47vT6FuG23zxr6n58CHh+g/6hrKFlPGoZwjELU2YCk
2orNIpHzBFNZ24vykNqwZGEOkkD6C38lLTP9d8dPnxnkzQaQ7pwneM4Zymb6rsXH
wayqefeF4+88lMveRHDRTQPB4X7HsZ8hiFlpvyiYg59vsS5NSUBiBDt412Q5K5NZ
VRmGZ85oN614kjV16wea1s1l79Thz5YH+wKqFBw5KK541HO/k+3uzmnBNf/P5eXU
rcGa06zid+Zwgq/t+zgATbX4fWalhmpJ+4fF62GDqH+DYpyhHG9PZ1BQColjyR+F
kSGEF/3mIhR+HrCt5O8otgzbRcbyZ4ntujqWdbZLp+CxUjwSQlg=
=w5Vf
-----END PGP SIGNATURE-----

--QPLhHumC/zyqoLsF--