Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 19 Apr 2024 08:34:49 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: shveta malik <shveta.malik@gmail.com>,
	"Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
	"Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	"Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Subject: Re: Disallow changing slot's failover option in transaction block
Message-ID: <ZiGuGZuuwnFfH8TL@paquier.xyz>
References: <OS0PR01MB57165542B09DFA4943830BF294082@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <OSBPR01MB255229D89C6D4A298F19E016F5082@OSBPR01MB2552.jpnprd01.prod.outlook.com>
 <CAJpy0uCCadKHEOT5cRT+EKwcmGuY2xxktaRgiNcS_RnFUcGYXQ@mail.gmail.com>
 <CAA4eK1J9jg1wKcgkmjq6tzbR-dLgxiT=563Pq2zYKGBNrtQN+A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="RBkTrUyZu9OOcPMg"
Content-Disposition: inline
In-Reply-To: <CAA4eK1J9jg1wKcgkmjq6tzbR-dLgxiT=563Pq2zYKGBNrtQN+A@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZiGuGZuuwnFfH8TL%40paquier.xyz>
Precedence: bulk


--RBkTrUyZu9OOcPMg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Apr 18, 2024 at 11:22:24AM +0530, Amit Kapila wrote:
> +1 for option 2 as it sounds logical to me and consistent with ALTER
> SUBSCRIPTION. BTW, IIUC, you are referring to: "When altering the
> slot_name, the failover and two_phase property values of the named
> slot may differ from the counterpart failover and two_phase parameters
> specified in the subscription. When creating the slot, ensure the slot
> properties failover and two_phase match their counterpart parameters
> of the subscription." in docs [1], right?

FWIW, I'd also favor option 2, mostly on consistency ground as it
would offer a better user-experience.  On top of that, you're saying
that may lead to some simplifications in the CREATE path.  Without a
patch, it's hard to tell, though.

As far as I can see, this is not tracked as an open item and it should
be.  So I have added one.
--
Michael

--RBkTrUyZu9OOcPMg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmYhrhkACgkQnvQgOdby
QH23eg/+MHxwKJN8TKvnmWBwY6X/cfs/GjhLQzyTMHuKaw1bnTRwwr54GMwJmJ4B
nU11YTfDO9t68pIb6Z0TsSrh9OIP4ZBIWcN2yZFQgDFr+muuFw3L1sA5MGpCypMV
sE/7NgVFOGHeJ8lZ6IacnMB5q0ZFzCnwVCYkwwDczH+0KjkxwndAPuI7pO56V86l
CMde02EDS/cVFtFZ8Q+BUJpXb+YRxybnCpciPsnQKLHtsv+Mv5H6Rurdye24orl2
kIIp5os+RG692thYCJJCx1Avpai4hmNiYc9YNqrfo6a0V4ZhxOw86HO88Iu7Ad1s
8rV5etVQdxp/pCTFcFopWjeU7HLqaS9QIpT5FDqWWx/dAKPGZns8ZgIQXqLfZ4nA
ccaDoABVTv3Hfd6ZKrLBBpZz8u2ikjtLyyXOeNZ1jC7A2jP7uhPBsUSHhmLJWG9R
JTj4lp6n9KZbJKdJ9CIPIeLnjOZQj8LllvpoSF6VTI3YMFp2l80aI6XetwqhWP6U
nJv9C628CDyiM4d2W5Nr8bK44xm/LKukZDpZy0sqN1taKDnFPWabyUwV/0a50GwK
nqhU89UXCo2lkJYG73gKyWlNGdkoWcotq4KnsvphmYF6rY0fLmhjxzFotNdsAH7Y
gl0k9WEIkexH8V5uv+zYSD2Y2ZWVIji7bQg5KP1wg8gWxH5u4Vs=
=t/PF
-----END PGP SIGNATURE-----

--RBkTrUyZu9OOcPMg--