Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 30 Apr 2024 07:42:52 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Richard Guo <guofenglinux@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: A failure in prepared_xacts test
Message-ID: <ZjAibGF5tvKWjJDs@paquier.xyz>
References: <CAMbWs4-mWCGbbE_bne5=AfqjYGDaUZmjCw2+soLjrdNA0xUDFw@mail.gmail.com>
 <Zi8pC2WkIL56cHmj@paquier.xyz>
 <1068977.1714367460@sss.pgh.pa.us>
 <Zi8vNgPIaeUP5-iM@paquier.xyz>
 <1076837.1714368760@sss.pgh.pa.us>
 <Zi9E9h-S2cRkumqb@paquier.xyz>
 <CAMbWs48uTLZT14aaBaEg7cpB6ercU5wm9+WfGLGC3VoP28gfCA@mail.gmail.com>
 <1222343.1714398316@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="r8Uhw88vAmx8q8SB"
Content-Disposition: inline
In-Reply-To: <1222343.1714398316@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/ZjAibGF5tvKWjJDs%40paquier.xyz>
Precedence: bulk


--r8Uhw88vAmx8q8SB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Apr 29, 2024 at 09:45:16AM -0400, Tom Lane wrote:
> TAP tests shouldn't be at risk, because there is no "make
> installcheck" equivalent for them.  Each TAP test creates its own
> database instance (or maybe several), so that instance won't have
> anything else going on.

There are a few more 2PC transactions in test_decoding (no
installcheck), temp.sql, test_extensions.sql and pg_stat_statements's
utility.sql (no installcheck) but their GIDs are not that bad.
twophase_stream.sql has a GID "test1", which is kind of generic, but
it won't run in parallel.  At the end, only addressing the
prepared_xacts.sql and the ECPG bits looked enough to me, so I've
tweaked these with 7e61e4cc7cfc and called it a day.

I'd be curious about any discussion involving the structure of the
meson tests.
--
Michael

--r8Uhw88vAmx8q8SB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmYwImwACgkQnvQgOdby
QH0DZg/+Nigat8lGoTjaPzTCVqC/dd6lJmr39tU4sghZK34QbHUHQGaxSOxrNmSU
zj96IlgDa7zgjWg76LzwRzz2az/5fyaiA/nVY+JpkyrkemtnsEMopJkruAH/xE8e
iNfk+ZzjZ51a165mXn6ln3ZOXuV19bUYTLxopNwHT+z6KLD6Cxo+ZSPpJbLwVSkT
HZy86cM80sSPxWnaN4udPeYue30B09tYPyOqo1fn/xCDUBnVj0W5DPa8XRUTbi0p
jGCve3g+B3dnsTGpdrMBES5qmShyWh3TfLlzWV9VYD3A+BBYkPtKDX6XBYRGTeuT
SvWt7oyuxVjLBvwk7cj80rhGEFETg51IxRifPdJCG4ZdXiheK1F+7NWXhLdcBnkH
qQmAnLeCWVlK3XwjTmLdPryRhN2JyhwOeMkI+z56ojuUZKcws9PpR0KBYL023S5a
Cchx+JaQnfPEfO83SgyXcfUBNxuAOagjvVqH8z+qbAS+g15Lv3TcrONf3eWwGo1A
n8R5PjAZladZ/Humr/3OTx0SeQCoP8xPDLD/4cl1WEwLYO8y9I3IAIuEi6iMAZr0
M65yB+ewjJmkjv8IBNTx9KyNNqTNIy6uUSxdkgzJFGDwXS3bsrMB8C49pfGGpe0a
3QzlfLLCvvFUH+49QfQ+mGeFcjX3DCfHg6Fv1+1zodNEDkxe3GA=
=5R2F
-----END PGP SIGNATURE-----

--r8Uhw88vAmx8q8SB--