Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 7 May 2024 11:50:05 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tristan Partin <tristan@neon.tech>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
	Andres Freund <andres@anarazel.de>
Subject: Re: Use pgstat_kind_infos to read fixed shared stats structs
Message-ID: <ZjmW3ZI1HbVyfDpZ@paquier.xyz>
References: <D12SQ7OYCD85.20BUVF3DWU5K7@neon.tech>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="9mTjbQht5pSxBtlh"
Content-Disposition: inline
In-Reply-To: <D12SQ7OYCD85.20BUVF3DWU5K7@neon.tech>
Archived-At: <https://www.postgresql.org/message-id/ZjmW3ZI1HbVyfDpZ%40paquier.xyz>
Precedence: bulk


--9mTjbQht5pSxBtlh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, May 06, 2024 at 02:07:53PM -0500, Tristan Partin wrote:
> This was originally thought of by Andres in
> 5891c7a8ed8f2d3d577e7eea34dacff12d7b6bbd.

+1 because you are removing a duplication between the order of the
items in PgStat_Kind and the order when these are read.  I suspect
that nobody would mess up with the order if adding a stats kind with a
fixed number of objects, but that makes maintenance slightly easier in
the long-term :)

> Not a fix, per se, but it does remove a comment. Perhaps the discussion will
> just lead to someone deleting the comment, and keeping the code as is.
> Either way, a win :).

Yup.  Let's leave that as something to do for v18.
--
Michael

--9mTjbQht5pSxBtlh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmY5lt0ACgkQnvQgOdby
QH3eJA/+MNv1/tQDwP4R4eHIPwrJtKryJF8OuaRDJjN/5gIRqIbQDf0Kiu6zus16
/y4kSJqKl36HN8ig5nGm9ZErGwV0a1C8ZntUmm2pWDM1rQSuoFhNjBl/GrMNN2v2
ZANUqG5Zrfy8KHD7Xr6p/GAJlDmwKZgjzHrFrlbbM0A8y85wJ5C3jxUVhEL5pPvt
36nDfMf3kP3BXVT0mlqMr0Nk8fYWcWpEhC241g9VwXRrGU/mv/JNLGsu8NERqgOS
00CFUUwiLhiaN4KWRotawlOPUKXYRJWVEg8dt5Hy6bakjPNaHoJbGQ+qEqRzBAxT
pMn2TV6/3ZtYxoEg2Z7+Fhs/alrMqBUYSwtWJCAZrehBStFJLymQKV+IpwvPyrgh
h/YTplt5lB319Km+B/Hln3xPHqXivzana49P9sRnXrmznhNM6cMsvwh+onI2Bkpm
h4uAxDCX+5bbZcnJNg1lKpXsuqjdsLEBBR1eMBPkvQ59xTkeMtv4LFM3uPtYjbit
KG30nIvt0Fgb6yy81dV01v/l2fAR+mNYSWKRNb1XLmiLt11irZsKvFnaI7ufVEjV
PI05EOSox+qQY54UCM0hQs0YdxlbwH+NeFrJ/s4HvScBWMQbjDNljxrVJQlvv/oL
jCF2qlfrlu+2MATAQi9xpEm+zbi8VrJYYQ99hMl22k1zXpKGrBI=
=0FTF
-----END PGP SIGNATURE-----

--9mTjbQht5pSxBtlh--