Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s6Hoj-00BGag-MV for pgsql-hackers@arkaria.postgresql.org; Sun, 12 May 2024 22:37:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1s6Hni-00Dbn5-C0 for pgsql-hackers@arkaria.postgresql.org; Sun, 12 May 2024 22:36:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s6Hng-00Dbmw-Op for pgsql-hackers@lists.postgresql.org; Sun, 12 May 2024 22:36:14 +0000 Received: from wfhigh7-smtp.messagingengine.com ([64.147.123.158]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s6Hnc-000ivh-4g for pgsql-hackers@postgresql.org; Sun, 12 May 2024 22:36:12 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.west.internal (Postfix) with ESMTP id BCF101800082; Sun, 12 May 2024 18:36:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 12 May 2024 18:36:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1715553364; x=1715639764; bh=w8ZTvbTCBF pBaBVesXOyfZUwP3xO705jwRIqeVVMX2A=; b=n6rn8RJ63nh5VTyXlwzvC7HKAy aN0oVhXitgWb8becx5TAmiV0BI+gqa0EVHpVl+TWMQ9XBaayqFZ9Guj7iZeLEibP IGSWKYGi4I3GZsUKM65+dIfQhojvF72jWYRpKPV+gMZHj+5bVLuj9j/dkoen0h9O uR3USbJmmUogWIJO6OaOrl6blky1Dx6kYyKs3AbrolNqFTj47cFFPdE9T8aWmu8j kIBobX0Z64bEfQjhSF8nNE7idOtIoEG8BVbj1NUC1UaPgjO+96aIo/fazInJeq36 oHiDbIU8EjhkSs21Pr14tiEFf2Kb+veVP7mVQUSAVoCi3nW4aBk7SczucfGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1715553364; x=1715639764; bh=w8ZTvbTCBFpBaBVesXOyfZUwP3xO 705jwRIqeVVMX2A=; b=aVllrpTcjsnufAVSbfgJCErGwLXZZHH08kuPNdPyFzRt 2F6GWk54FW/DCkpRAnh99JZm9OgEwvnpEN0kG3MFIUuYboDdZ/4xQj8HTD08n3OS iVbIArWsd4GVNLGPalH4I3TbdRIJdrZqOHnitNut+ZDkI+Ta3WyHIhJjWRKSa5fD jVaLsrRivCxAwUZvZUEDN8qm+L8Teceo4gyx9iRkb81rWDn0jx58OZPZbklwMJFE JQW/GipdtRH5IZcpW8sPCsO4LRhi1aGwzK6ZbzcBXBMvaU+WUFDEmEC8w0D+mr5r UAbX6bRbvHxibeGaPXeRSv9XX+BLCVrZZPVnr2I7Kw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdegfedgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 12 May 2024 18:36:02 -0400 (EDT) Date: Mon, 13 May 2024 07:35:48 +0900 From: Michael Paquier To: Noah Misch Cc: Heikki Linnakangas , Tom Lane , pgsql-hackers Subject: Re: Weird test mixup Message-ID: References: <20240506212324.2e.nmisch@google.com> <20240507185310.d3@rfd.leadboat.com> <20240509031553.47@rfd.leadboat.com> <20240509233900.4e.nmisch@google.com> <20240512174851.b9.nmisch@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kC4ZB/kjBEQQ2lh3" Content-Disposition: inline In-Reply-To: <20240512174851.b9.nmisch@google.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --kC4ZB/kjBEQQ2lh3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, May 12, 2024 at 10:48:51AM -0700, Noah Misch wrote: > This looks correct, and it works well in my tests. Thanks. Thanks for looking. While looking at it yesterday I've decided to split the change into two commits, one for the infra and one for the module. While doing so, I've noticed that the case of a private area passed as NULL was not completely correct as memcpy would be undefined. The open item has been marked as fixed. -- Michael --kC4ZB/kjBEQQ2lh3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmZBREQACgkQnvQgOdby QH2lFg/6A5u3YefYBitLLktD0sz4CVF5WpurnEWmzGZqglCwVBvGnvpfAGaWwWQS 7uDhmpF1dDvLMW/HnyehTIPFjbXwO0dnwh6sbC+JqZP+Luaw0d/qI2mZMCuJuj+C QmM+au2S3oVqaaIIiQEUqJZD+pxsqYaGohrd0PDBCgo2MoTGWovS/7Ddc4qQuVeJ qUa+FjFaf9MbxIgeoAK7hhHrYEfXStjBQ8FVol3r6jCoSdfvK0iduEnyyS5Vb6+s mnpZYDOChGBtAOiE/+NlEYXzduT6S/P8g7h0/JEG0XL+NKyhs86ttsEqJmKdfMBf 2g4hiAKJ4Mi0nN+EtLTmVLo/ViCBwTgQCw/0M7yt+bM/MUl/VIFsqK+ZnDSEw1iw EhvdSfQFrh7nbScFodSZozDXMIgl3RAUyGg3cMYYRuErXp7VY7abyT/wuRfh9x0q o5p5/iMf9VWp0cKc7IgS7lCjEjxok8TZj+w42LkosffKeAdhph7IsumVKMU9LGPj bYgIYL9P72MZqWzdzWvKYxCeWZahYpGNxvusil+jPbWAsMhU/O9C/BLOZzKUV53o mk5qGX1stEh4SpuUU57wugZpxRfQDuudaRTkn/Oo2PmvHDENwzOqtOETQZzBjPcD /uUk077citZEJtBJbTC8NYq9DzK34W3wO5aF/uDVPTvkQYZMxLI= =92cq -----END PGP SIGNATURE----- --kC4ZB/kjBEQQ2lh3--