Date: Mon, 13 May 2024 20:56:26 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Joe Conway <mail@joeconway.com>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>, Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: First draft of PG 17 release notes
Message-ID: <ZkK2uqJ-m_2WgLWR@momjian.us>
References: <ZjxLJpnH4VMkOMmi@momjian.us>
 <CAGECzQTz5aUqLEL6daLd2Hu2FXS_LOSh4keDndJ1fwThsb_b5w@mail.gmail.com>
 <Zj6PvZWzkTsCwNMS@momjian.us>
 <1641606.1715376693@sss.pgh.pa.us>
 <CAGECzQQRxCzr5KuoK6LZpsoKPYZwJ4_gtW6de-cikKECqPcsoA@mail.gmail.com>
 <6233479a-0e58-464c-8ff1-311e076a9c00@joeconway.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="lqQc6EVnSMya7OFo"
Content-Disposition: inline
In-Reply-To: <6233479a-0e58-464c-8ff1-311e076a9c00@joeconway.com>
Archived-At: <https://www.postgresql.org/message-id/ZkK2uqJ-m_2WgLWR%40momjian.us>
Precedence: bulk


--lqQc6EVnSMya7OFo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, May 11, 2024 at 10:24:39AM -0400, Joe Conway wrote:
> On 5/11/24 09:57, Jelte Fennema-Nio wrote:
> > On Fri, 10 May 2024 at 23:31, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > > 
> > > Bruce Momjian <bruce@momjian.us> writes:
> > > > I looked at both of these.   In both cases I didn't see why the user
> > > > would need to know these changes were made:
> > > 
> > > I agree that the buffering change is not likely interesting, but
> > > the fact that you can now control-C out of a psql "\c" command
> > > is user-visible.  People might have internalized the fact that
> > > it didn't work, or created complicated workarounds.
> > 
> > The buffering change improved performance up to ~40% in some of the
> > benchmarks. The case it improves mostly is COPY of large rows and
> > streaming a base backup. That sounds user-visible enough to me to
> > warrant an entry imho.
> 
> +1

Attached patch applied.


-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.

--lqQc6EVnSMya7OFo
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="master.diff"

commit e87e7324555
Author: Bruce Momjian <bruce@momjian.us>
Date:   Mon May 13 20:55:13 2024 -0400

    doc PG 17 relnotes:  add item about libpq large data transfers
    
    Reported-by: Jelte Fennema-Nio
    
    Discussion: https://postgr.es/m/CAGECzQTz5aUqLEL6daLd2Hu2FXS_LOSh4keDndJ1fwThsb_b5w@mail.gmail.com
    
    Reviewed-by: Joe Conway
    
    Backpatch-through: master

diff --git a/doc/src/sgml/release-17.sgml b/doc/src/sgml/release-17.sgml
index 9dd3954f3c2..38c14970822 100644
--- a/doc/src/sgml/release-17.sgml
+++ b/doc/src/sgml/release-17.sgml
@@ -1901,6 +1901,17 @@ Add libpq function PQsetChunkedRowsMode to allow retrieval of results in chunks
 </para>
 </listitem>
 
+<!--
+Author: David Rowley <drowley@postgresql.org>
+2024-04-07 [c4ab7da60] Avoid needless large memcpys in libpq socket writing
+-->
+
+<listitem>
+<para>
+Allow libpq to more efficiently transfer large blocks of data (Melih Mutlu)
+</para>
+</listitem>
+
 <!--
 Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
 2024-04-08 [d39a49c1e] Support TLS handshake directly without SSLRequest negoti

--lqQc6EVnSMya7OFo--