Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s6lGJ-001bq6-D7 for pgsql-hackers@arkaria.postgresql.org; Tue, 14 May 2024 06:03:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1s6lGH-009xBb-9N for pgsql-hackers@arkaria.postgresql.org; Tue, 14 May 2024 06:03:41 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s6lGG-009xBS-W8 for pgsql-hackers@lists.postgresql.org; Tue, 14 May 2024 06:03:41 +0000 Received: from fhigh2-smtp.messagingengine.com ([103.168.172.153]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s6lGE-0007Ba-B4 for pgsql-hackers@postgresql.org; Tue, 14 May 2024 06:03:39 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 44D7D1140141; Tue, 14 May 2024 02:03:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 14 May 2024 02:03:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1715666617; x=1715753017; bh=ZkmM8FLmgW cmjthob9B6kAaFUD+gk2gQ9X468UD6Rw0=; b=lMKZBGv9wOHag1KiXFFMsX0zvs cM9EaYqsDlUk4j6JkDdkjwuMj0XbdzEMj9pexTcM1VGSlU9bfEAf4/9t9/3VQBlA KXOgm+AkJEuVUs5yhjYx1hLgXxpV6DYSmLn841MuN541UhtLo2rabQeXZUVMf5Vx AoyYuq1Ec52LRtnhUPzLGRfrKB/B3I+YO9TqO44DEORzb8iN7xTsMBgFekAZOhCm DwlpnjbsuYAXrLc5r+vY072TV7YiqIBqGhcaAgJ2A67xffBsklHsvOtG6gQdSO2h clNFWcjpyWA1N+IJe6Ua9VbDSBFHi434wXJYVi4s+SA7oAgMqaACanAmwhpA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1715666617; x=1715753017; bh=ZkmM8FLmgWcmjthob9B6kAaFUD+g k2gQ9X468UD6Rw0=; b=GokUk9xgyk9qqrKj3fMANtz2Comp5jP+vKpcJvjDvYWK k07C2/+e9lKmqSivfVVgU0BwSQAC0tT4y6EL6hsY7ykHMuUEijy8xVbdypmWAGut 9Opg7YbRkFue6DsJf1aMooupUVrsmUD0JB2OmC5jpFSCeuN4nV7l5Q0LDja5dHuq 91Mej8uhYqoIPLF7QnPbRWJtbAOgXdpl1wiuyfryBo409YkXAQZg5QD0WMzA75gd NzgdL5dZE0PulOis6epaZoX493GFLZIutHd0Q+JE6tMBEIEM+JhmZyGJuvK1fkqe amFjt9rNAozwDR8IzDJDREX2snMb5+VxlFNdJFfwjw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeghedgleehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 May 2024 02:03:35 -0400 (EDT) Date: Tue, 14 May 2024 15:03:22 +0900 From: Michael Paquier To: Daniel Gustafsson Cc: Ranier Vilela , PostgreSQL Hackers Subject: Re: Fix resource leak (src/backend/libpq/be-secure-common.c) Message-ID: References: <88E977CA-5951-4D51-B594-489ACF3DA10C@yesql.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JRI3xZIrzDdskk7n" Content-Disposition: inline In-Reply-To: <88E977CA-5951-4D51-B594-489ACF3DA10C@yesql.se> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --JRI3xZIrzDdskk7n Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 13, 2024 at 08:06:57PM +0200, Daniel Gustafsson wrote: >> Any chance we'll have these fixes in v17? >=20 > Nice timing, I was actually rebasing them today to get them committed. Looks sensible seen from here, as these paths could use a LOG or rely on a memory context permanent to the backend causing junk to be accumulated. It's not that much, still that would accumulate. -- Michael --JRI3xZIrzDdskk7n Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmZC/qoACgkQnvQgOdby QH3FyhAApSEV9xVDEk0VAgzlm3q79ZHTLL8672ymkjnnsVJsIX/30gdD50tDoeib DKRsYbAd9Q6G45IDmQrWqiQeyuU11sxiJO0G/sLFpexCS3adg/sd7s3rFe8N0S+P srfnv/jd+754UF/l02NvZ/6j/dPhsXnGW6xX/B0g2+WIbwzFUVRSx6wEtlXt48Np MFyAn70RfSLG9Vg0gxu3GNI5567DFcx1RV3B7XHy154WOqozNVqBlZkkO49NiYdj 4sxzI6P6JLF825pknAPziZaXrjbk3ywUupDvVCaqNwAzukejk4w/Du0pJCH2wbxj 83xj7KUU5NwoRuAoVTeScElDmxrgndhu5MjYt+6ZKGr5SUMbUboqmsDpu/uvt9wR WSMrrSLZIFch1vdrfIIdzHraKPjR7wJwssg+XoZDOuZe4zEepLeQeJwu+OGWu4pY DxM10Exgs48I486b+FHf3gPRb/JgCTTkXyxiguJll9wtZYqV94QK1sIzc14E0EkV vw9wm2sR7TP1EU7ijNXSrj6GWy8qa6KJeKs99dqyUAYtIph3KHzeIwNv4fQxAdu6 6C0g7YgoZEbdqXHvBatUDVKOBHlUaiXaLLyUl3mU3ZRwVDXGz+aR+x8IMDZKrhz5 bPM2d6iTw+NbsgLWnY/GT1xMihduTY5Ukcit4sZZ+6k1k9i3hc0= =zQ85 -----END PGP SIGNATURE----- --JRI3xZIrzDdskk7n--