Date: Tue, 14 May 2024 20:47:10 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Joe Conway <mail@joeconway.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: First draft of PG 17 release notes
Message-ID: <ZkQGDn0Gu5FJuTko@momjian.us>
References: <ZjxLJpnH4VMkOMmi@momjian.us>
 <CAGECzQTz5aUqLEL6daLd2Hu2FXS_LOSh4keDndJ1fwThsb_b5w@mail.gmail.com>
 <Zj6PvZWzkTsCwNMS@momjian.us>
 <1641606.1715376693@sss.pgh.pa.us>
 <CAGECzQQRxCzr5KuoK6LZpsoKPYZwJ4_gtW6de-cikKECqPcsoA@mail.gmail.com>
 <6233479a-0e58-464c-8ff1-311e076a9c00@joeconway.com>
 <ZkK2uqJ-m_2WgLWR@momjian.us>
 <CAGECzQSFA47rzPSgRcezfJdBOtTwEF0oCNsh_gKDkXDCCZVWXw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="dBHx46ivcLJPpM3T"
Content-Disposition: inline
In-Reply-To: <CAGECzQSFA47rzPSgRcezfJdBOtTwEF0oCNsh_gKDkXDCCZVWXw@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZkQGDn0Gu5FJuTko%40momjian.us>
Precedence: bulk


--dBHx46ivcLJPpM3T
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 14, 2024 at 02:20:24PM +0200, Jelte Fennema-Nio wrote:
> On Tue, 14 May 2024 at 02:56, Bruce Momjian <bruce@momjian.us> wrote:
> >
> > On Sat, May 11, 2024 at 10:24:39AM -0400, Joe Conway wrote:
> > > On 5/11/24 09:57, Jelte Fennema-Nio wrote:
> > > > The buffering change improved performance up to ~40% in some of the
> > > > benchmarks. The case it improves mostly is COPY of large rows and
> > > > streaming a base backup. That sounds user-visible enough to me to
> > > > warrant an entry imho.
> > >
> > > +1
> >
> > Attached patch applied.
> 
> I think we shouldn't list this under the libpq changes and shouldn't
> mention libpq in the description, since this patch changes
> src/backend/libpq files instead of src/interfaces/libpq files. I think
> it should be in the "General performance" section and describe the
> change as something like the below:
> 
> Improve performance when transferring large blocks of data to a client
> 
> PS. I completely understand that this was not clear from the commit message.

Okay, I went with your wording.  Attached patch applied.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.

--dBHx46ivcLJPpM3T
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="master.diff"

diff --git a/doc/src/sgml/release-17.sgml b/doc/src/sgml/release-17.sgml
index a3b4a8fb3b9..448f5653bc5 100644
--- a/doc/src/sgml/release-17.sgml
+++ b/doc/src/sgml/release-17.sgml
@@ -563,6 +563,17 @@ Improve performance of heavily-contended WAL writes (Bharath Rupireddy)
 </para>
 </listitem>
 
+<!--
+Author: David Rowley <drowley@postgresql.org>
+2024-04-07 [c4ab7da60] Avoid needless large memcpys in libpq socket writing
+-->
+
+<listitem>
+<para>
+Improve performance when transferring large blocks of data to a client (Melih Mutlu)
+</para>
+</listitem>
+
 <!--
 Author: Thomas Munro <tmunro@postgresql.org>
 2024-04-03 [210622c60] Provide vectored variant of ReadBuffer().
@@ -1923,17 +1934,6 @@ Add libpq function PQsetChunkedRowsMode to allow retrieval of results in chunks
 </para>
 </listitem>
 
-<!--
-Author: David Rowley <drowley@postgresql.org>
-2024-04-07 [c4ab7da60] Avoid needless large memcpys in libpq socket writing
--->
-
-<listitem>
-<para>
-Allow libpq to more efficiently transfer large blocks of data (Melih Mutlu)
-</para>
-</listitem>
-
 <!--
 Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
 2024-04-08 [d39a49c1e] Support TLS handshake directly without SSLRequest negoti

--dBHx46ivcLJPpM3T--