Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 18 May 2024 20:37:35 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Will Mortensen <will@extrahop.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Jingxian Li <aqktjcm@qq.com>,
	andres <andres@anarazel.de>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] LockAcquireExtended improvement
Message-ID: <ZkiS_3q_EHrwYIlJ@paquier.xyz>
References: <tencent_11D01D86DFF79B0A300BC1C7A4B6F0D9790A@qq.com>
 <CA+TgmoYhmf14R9DPfdqx-ym+YV8dzMfwDR+e2qrj07BJ8=bz0Q@mail.gmail.com>
 <tencent_1BB753C5F9D03D240E63EE8F4C639829E009@qq.com>
 <CA+TgmoaYwx7iCfB88xRykMTTORA+1MYkczzmykt4=W=DYTyKMw@mail.gmail.com>
 <202402081828091711555@qq.com>
 <tencent_6E053E4F8FB5C388FB1E5323E64C78875407@qq.com>
 <CA+TgmoaZNzNywg+jBXOYcsYbF5gdcY8+y5P5FofEEs6uyaN7_A@mail.gmail.com>
 <CA+TgmoYc56fSB-CcO3dJiwEAT8DP6ybmQS0+xb3ucWVMXjTXHw@mail.gmail.com>
 <CAMpnoC5f+eiS7tdy8PUpd_LacSTVT-pYpVooKfjHRQQmkHPZ2g@mail.gmail.com>
 <CAMpnoC7uymaewKschMUy5703xfi31ivjZiFKyurjQ=MWqLnP-Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="8N4RVyHvuVkP4mp7"
Content-Disposition: inline
In-Reply-To: <CAMpnoC7uymaewKschMUy5703xfi31ivjZiFKyurjQ=MWqLnP-Q@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZkiS_3q_EHrwYIlJ%40paquier.xyz>
Precedence: bulk


--8N4RVyHvuVkP4mp7
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 17, 2024 at 11:38:35PM -0700, Will Mortensen wrote:
> On Tue, Mar 26, 2024 at 7:14=E2=80=AFPM Will Mortensen <will@extrahop.com=
> wrote:
>> This comment on ProcSleep() seems to have the values of dontWait
>> backward (double negatives are tricky):
>>
>>     * Result: PROC_WAIT_STATUS_OK if we acquired the lock,
>> PROC_WAIT_STATUS_ERROR
>>     * if not (if dontWait =3D true, this is a deadlock; if dontWait =3D =
false, we
>>     * would have had to wait).
>>
>> Also there's a minor typo in a comment in LockAcquireExtended():
>>
>>     * Check the proclock entry status. If dontWait =3D true, this is an
>>     * expected case; otherwise, it will open happen if something in the
>>     * ipc communication doesn't work correctly.
>>
>> "open" should be "only".
>=20
> Here's a patch fixing those typos.

Perhaps, this, err..  Should not have been named "dontWait" but
"doWait" ;)

Anyway, this goes way back in time and it is deep in the stack
(LockAcquireExtended, etc.) so it is too late to change: the patch
should be OK as it is.
--
Michael

--8N4RVyHvuVkP4mp7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmZIkv8ACgkQnvQgOdby
QH0m0w//TYEnyLebLTa517xInSkvR3kwyXY9z8cGl+BM/tYgC0mVDiruWVjTBV48
OX+o+92onX+zOuEfmlwpDSiLWRMGMxe4FY2pCeLjqtrLi6wrx7yM/tDR2P4iDDpz
Dc+EOff65P8+wmjisN2AhBsZXKhmrWERH65Up++n11jkhL/4Jzuyrz+vOjSDPg9e
m2GQU7VciroivPRq7E8Rg39aYraR/XeO25pfGPmuV72fJRkFAP/Df5RoF8VTg7RM
JC12wAjs/jEFXaqZY6gAzYeKdq9qlJNUeFN30VclLCkOSNOD7zZmWAzC+SW1FAyO
xv1HFCf7KejFfoVL4gq2hjdHMEF0daZr7nbNgd08Hu3Qb4X3GZd90vD+yRznwGwt
vSW8D45xcZLlnCbEvPeNBXqz/F9DHsjRYT0EEmYL0f6QWQ/lEMSBY68Iw0uybGjU
NxZboVi+4lfWPSEHMZt+4XVJD4MzmR/i6uNWNXVkq5QB+HLaxxRppucykszJLI90
RBZ5JQDGLOFrWU6CLGKglvJOp6tE+0hD2/45RomqQlX2HPJEvw4pAXx/SKy0RRg1
0GcRPftwmxvPEtTjALC5xSs3DzXJ5KSQcnZCEA/K1HOFS6G24i/zW42RGvnX3tgS
6z8IBJ4yFV8eR0KqIumhotg7DN/Z8Xd95XjJbI6J5qoCYpyvrDs=
=mCQ4
-----END PGP SIGNATURE-----

--8N4RVyHvuVkP4mp7--