Date: Mon, 3 Jun 2024 14:04:19 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: "Imseih (AWS), Sami" <simseih@amazon.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Justin Pryzby <pryzby@telsasoft.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: problems with "Shared Memory and Semaphores" section of docs
Message-ID: <Zl4TswfwPUZkHHfn@nathan>
References: <20240517164452.GA1914161@nathanxps13>
 <2463906.1715965795@sss.pgh.pa.us>
 <20240517174837.GB1918496@nathanxps13>
 <20240517192123.GA1933425@nathanxps13>
 <ZkzyBOD-cX35wKuM@nathan>
 <F4131F24-A20F-4A04-B1A6-60242A7C7A43@amazon.com>
 <Zl363er4TUbOkJEf@nathan>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="vn2DWUXFU3EakOwp"
Content-Disposition: inline
In-Reply-To: <Zl363er4TUbOkJEf@nathan>
Archived-At: <https://www.postgresql.org/message-id/Zl4TswfwPUZkHHfn%40nathan>
Precedence: bulk


--vn2DWUXFU3EakOwp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jun 03, 2024 at 12:18:21PM -0500, Nathan Bossart wrote:
> On Tue, May 21, 2024 at 11:15:14PM +0000, Imseih (AWS), Sami wrote:
>> As far as backpatching the present inconsistencies in the docs,
>> [0] looks good to me.
> 
> Committed.

Of course, as soon as I committed this, I noticed another missing reference
to max_wal_senders in the paragraph about POSIX semaphores.  I plan to
commit/back-patch the attached patch within the next couple days.

-- 
nathan

--vn2DWUXFU3EakOwp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="add_missing_max_wal_sender_reference.patch"

diff --git a/doc/src/sgml/runtime.sgml b/doc/src/sgml/runtime.sgml
index 883a849e6f..2f7c618886 100644
--- a/doc/src/sgml/runtime.sgml
+++ b/doc/src/sgml/runtime.sgml
@@ -884,7 +884,8 @@ psql: error: connection to server on socket "/tmp/.s.PGSQL.5432" failed: No such
     When using POSIX semaphores, the number of semaphores needed is the
     same as for System V, that is one semaphore per allowed connection
     (<xref linkend="guc-max-connections"/>), allowed autovacuum worker process
-    (<xref linkend="guc-autovacuum-max-workers"/>) and allowed background
+    (<xref linkend="guc-autovacuum-max-workers"/>), allowed WAL sender process
+    (<xref linkend="guc-max-wal-senders"/>), and allowed background
     process (<xref linkend="guc-max-worker-processes"/>).
     On the platforms where this option is preferred, there is no specific
     kernel limit on the number of POSIX semaphores.

--vn2DWUXFU3EakOwp--