Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 4 Jun 2024 08:30:19 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, kuroda.hayato@fujitsu.com,
	shlok.kyal.oss@gmail.com, pgsql-hackers@lists.postgresql.org,
	Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: pg_ctl start may return 0 even if the postmaster has been
 already started on Windows
Message-ID: <Zl5SC_kboY7i0AS8@paquier.xyz>
References: <20231024.172536.511643991820398116.horikyota.ntt@gmail.com>
 <CA+TgmoaYOON0cQPR0Aj_ZD2005+sschuMisSQV7xPqzxrx7vaQ@mail.gmail.com>
 <ZZyV99g76Q3-YwEn@paquier.xyz>
 <20240111.173322.1809044112677090191.horikyota.ntt@gmail.com>
 <CA+TgmoZt44PEeX_=5D7RtpKShPckMyZ9+xQkTnrKU5rnZWjfpQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="NOUu3ZDP67VpPYOh"
Content-Disposition: inline
In-Reply-To: 
 <CA+TgmoZt44PEeX_=5D7RtpKShPckMyZ9+xQkTnrKU5rnZWjfpQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Zl5SC_kboY7i0AS8%40paquier.xyz>
Precedence: bulk


--NOUu3ZDP67VpPYOh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jan 15, 2024 at 01:34:46PM -0500, Robert Haas wrote:
> This kind of change looks massively helpful to me. I don't know if it
> is exactly right or not, but it would have been a big help to me when
> writing my previous review, so +1 for some change of this general
> type.

During a live review of this patch last week, as part of the Advanced
Patch Workshop of pgconf.dev, it has been mentioned by Tom that we may
be able to simplify the check on pmstart if the detection of the
postmaster PID started by pg_ctl is more stable using the WIN32
internals that this patch relies on.  I am not sure that this
suggestion is right, though, because we should still care about the
clock skew case as written in the surrounding comments?  Even if
that's OK, I would assume that this should be an independent patch,
written on top of the proposed v6-0001.

Tom, could you comment about that?  Perhaps my notes did not catch
what you meant.
--
Michael

--NOUu3ZDP67VpPYOh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmZeUgsACgkQnvQgOdby
QH0BIxAAqLPRvYAZWWKPyCVwEGVpaQwpTbWPckr5jgyjnu4zee8fI04uLxUCXwgw
n0KLH7Hn3KdobhshCSiSyKApwrC6eisYqOjzJLG3k4mcYhaTSz16aJHIGF2t5c+k
pu7N0NVtXqgUAQOvhawGGbudowsf/79zGqOInPk6LLDF3YYF6anvoOdf5yn6XYye
QNqjx22aBW898XKjZ6Z0U1q5WmSjqYkANNjUVnuJz7ZJnzwD0b+u29ks0/lZkigg
2EoWM3m5h6+yAoH6czgQFoDOrjtBkYWMT1aqKzJXiLj76wbtWyQ3vap5rQSnXKJn
2poeMhnbQFgDHRDLo5oMlxX8rl8khQpO/sZdI3VCInEOnBMumWSeyOIfiCHhNRgY
ZZX84mTIm4/LFz2IQJwLMcN276C83TgdF+HR0SxovDyZg8ny8WNLW5GWiLyN7KwQ
UzxjwoxT6Rfjc2ru+0VYkuho5tyqaoFocapIXQI6jaCp743bMTeXRRK7j6bvtS1H
ovo3C0zgQ7ZbfIPFuIzhtkzTQOeKr4hrGm4ZDNgNuq8DGOykauO52YjHU1Ftpvxk
ioDdykRS9gN4DGc8K0iwn4rUhsRV4S4m0r9Qr3qE6+Ch5mPGiUtaq4moOjSk0GJY
TE01V0S8wq4ZQxqjtd4HM6hZodKI3Expz71JrJJGcDSSDEs7k/s=
=/MfS
-----END PGP SIGNATURE-----

--NOUu3ZDP67VpPYOh--