Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 5 Jun 2024 13:52:21 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, postgres@jeltef.nl,
	smithpb2250@gmail.com, vignesh21@gmail.com,
	jakub.wartak@enterprisedb.com, stark.cfm@gmail.com, hlinnaka@iki.fi,
	barwick@gmail.com, jchampion@timescale.com, pryzby@telsasoft.com,
	tgl@sss.pgh.pa.us, rjuju123@gmail.com, jakub.wartak@tomtom.com,
	pgsql-hackers@lists.postgresql.org,
	bharath.rupireddyforpostgres@gmail.com
Subject: Re: In-placre persistance change of a relation
Message-ID: <Zl_vBVP4dNMCu1vb@paquier.xyz>
References: <20240524.160916.2199777355532445323.horikyota.ntt@gmail.com>
 <CAGECzQRQzpE-EzJszHHvku1JLw+opu+KxE7rBqfyTmmgFwxrRQ@mail.gmail.com>
 <Zl5bKIdOWiHHb-9N@paquier.xyz>
 <20240604.160032.391318120410028809.horikyota.ntt@gmail.com>
 <Zl9-K3a0-AW4WZrl@nathan>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="FpxxFf0p30jaW0cw"
Content-Disposition: inline
In-Reply-To: <Zl9-K3a0-AW4WZrl@nathan>
Archived-At: 
 <https://www.postgresql.org/message-id/Zl_vBVP4dNMCu1vb%40paquier.xyz>
Precedence: bulk


--FpxxFf0p30jaW0cw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jun 04, 2024 at 03:50:51PM -0500, Nathan Bossart wrote:
> Bharath, does the multi-INSERT stuff apply when changing a table to be
> LOGGED?  If so, I think it would be interesting to compare it with the FPI
> approach being discussed here.

The answer to this question is yes AFAIK.  Look at patch 0002 in the
latest series posted here, that touches ATRewriteTable() in
tablecmds.c where the rewrite happens should a relation's
relpersistence, AM, column or default requires a switch (particularly
if more than one property is changed in a single command, grep for
AT_REWRITE_*):
https://www.postgresql.org/message-id/CALj2ACUz5+_YNEa4ZY-XG960_oXefM50MjD71VgSCAVDkF3bzQ@mail.gmail.com

I've just read through the patch set, and they are rather pleasant to
the eye.  I have comments about them, actually, but that's a topic for
the other thread.
--
Michael

--FpxxFf0p30jaW0cw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmZf7wUACgkQnvQgOdby
QH2VFRAAmpiNwKoUu+iWDVwS+SEM0Zer36oHOIq3NRyJOaYc4PvzK6Ys+OLFJ5M/
L0QZvXSS4sklb4/2LZx+yy7tnbfKjemPWykkiYRTAZ5AbTcramGkts5vZIk7H42U
osNT/dEsTYpO0rAbdpJks3rQaxCHpX+P+au6SgtzbjoHy4dBZ+MWEo0vviJaXpoS
KfLKpEi22HlFg48oY6UMAq+zEkTciWxAfkBxCFFCkVB3OoNMWrtYKs+Xf2pNyI27
KwsB9BdREmZeKeixPw6Y0sV1m3L8NuPxbrErHJSVgVO/DCDFc9LmLSIeyfe1IA9r
ie7iGhgcX7mPmCrJT2PC3VXkgza1R7lBpMpQLwMUQWeltRIMKEQCdXLVRaLGqc/e
g4V0Jnf4gZMcWavw3Grn+SKxQS2Hk2cU10FLuCiT8AtoQwQy0kxPDQLwMLvGRsIV
HJUX7Lv4QI3YNpeVI7DNpnGZ/zBKf3710XLnKznhaev+wVGVSJTdOSPt5o7p/dQK
b2igcTvv3v76jvfDW+YmlPWxa/lIFFXVudr5CNlbiquywcUDguQQpS6pznJi2xZl
KlNvQ4yOlYneA840zbE3hYxJgmRiobaTZUuzcnLXOtZ9t1QyflT0FOIKiSKFR1Hd
+Xc/OhshyOvBoZWV//BpMQDjDuX+52gUhdBjDls1Izs9DhnKMLg=
=BGsW
-----END PGP SIGNATURE-----

--FpxxFf0p30jaW0cw--