Date: Thu, 6 Jun 2024 14:51:42 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: "Imseih (AWS), Sami" <simseih@amazon.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Justin Pryzby <pryzby@telsasoft.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: problems with "Shared Memory and Semaphores" section of docs
Message-ID: <ZmITToZYnHJsMfWH@nathan>
References: <2463906.1715965795@sss.pgh.pa.us>
 <20240517174837.GB1918496@nathanxps13>
 <20240517192123.GA1933425@nathanxps13>
 <ZkzyBOD-cX35wKuM@nathan>
 <F4131F24-A20F-4A04-B1A6-60242A7C7A43@amazon.com>
 <Zl363er4TUbOkJEf@nathan>
 <Zl4TswfwPUZkHHfn@nathan>
 <ZmDM9dp9oY6Je8K7@nathan>
 <ZmIMQqOyDNLVsplz@nathan>
 <CA+TgmobWTmHcv9L_AgB5Vu9vQ34LBrdp8tD_O28kxDn74xhXmw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CA+TgmobWTmHcv9L_AgB5Vu9vQ34LBrdp8tD_O28kxDn74xhXmw@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZmITToZYnHJsMfWH%40nathan>
Precedence: bulk

On Thu, Jun 06, 2024 at 03:31:53PM -0400, Robert Haas wrote:
> I don't really like making this a GUC, but what's the other option?
> It's reasonable for people to want to ask the server how many
> resources it will need to start, and -C is the only tool we have for
> that right now. So I feel like this is a fair thing to do.

Yeah, this is how I feel, too.

> I do think the name could use some more thought, though.
> semaphores_required would end up being the same kind of thing as
> shared_memory_size_in_huge_pages, but the names seem randomly
> different. If semaphores_required is right here, why isn't
> shared_memory_required used there? Seems more like we ought to call
> this semaphores or os_semaphores or num_semaphores or
> num_os_semaphores or something.

I'm fine with any of your suggestions.  If I _had_ to pick one, I'd
probably choose num_os_semaphores because it's the most descriptive.

-- 
nathan