public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nathan Bossart <[email protected]>
To: jian he <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: CheckMyDatabase some error messages in two lines.
Date: Sun, 9 Jun 2024 21:02:37 -0500
Message-ID: <ZmZevewQ-8n8EWr_@nathan> (raw)
In-Reply-To: <CACJufxHHtvaGvV-=LD4OHAG-pM-1hyirKu8iW9+AuaN_NDskfA@mail.gmail.com>
References: <CACJufxHHtvaGvV-=LD4OHAG-pM-1hyirKu8iW9+AuaN_NDskfA@mail.gmail.com>

On Mon, Jun 10, 2024 at 08:00:00AM +0800, jian he wrote:
> https://www.postgresql.org/docs/devel/error-style-guide.html#ERROR-STYLE-GUIDE-FORMATTING
> "Don't end a message with a newline."
> 
> 
> accidentally, I found some error messages in the function
> CheckMyDatabase spread into two lines.
> so i try to consolidate them into one line.

> -				 errdetail("The database was initialized with LC_COLLATE \"%s\", "
> -						   " which is not recognized by setlocale().", collate),
> +				 errdetail("The database was initialized with LC_COLLATE \"%s\", which is not recognized by setlocale().", collate),

Both approaches produce the same message.  With the existing code, the two
string literals will be concatenated without newlines.  It is probably
split into two lines to avoid a long line in the source code.

-- 
nathan

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: CheckMyDatabase some error messages in two lines.
  In-Reply-To: <ZmZevewQ-8n8EWr_@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox