Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 11 Jun 2024 08:22:46 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
	jian he <jian.universality@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: CheckMyDatabase some error messages in two lines.
Message-ID: <ZmeKxgZ760tlzvBP@paquier.xyz>
References: <CACJufxHHtvaGvV-=LD4OHAG-pM-1hyirKu8iW9+AuaN_NDskfA@mail.gmail.com>
 <ZmZevewQ-8n8EWr_@nathan>
 <620742.1717985573@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="42472DpttqMhOiq/"
Content-Disposition: inline
In-Reply-To: <620742.1717985573@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/ZmeKxgZ760tlzvBP%40paquier.xyz>
Precedence: bulk


--42472DpttqMhOiq/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Jun 09, 2024 at 10:12:53PM -0400, Tom Lane wrote:
> No doubt.  People have done it both ways in the past, but I think
> currently there's a weak consensus in favor of using one line for
> such messages even when it runs past 80 columns, mainly because
> that makes it easier to grep the source code for a message text.

I recall the same consensus here.  Greppability matters across the
board.

> But: I don't see too much value in changing this particular instance,
> because the line break is in a place where it would not likely cause
> you to miss finding the line.  You might grep for the first part of
> the string or the second part, but probably not for ", which is not".
> If the line break were in the middle of a phrase, there'd be more
> argument for collapsing it out.

Not sure these ones are worth it, either, so I'd let them be.
--
Michael

--42472DpttqMhOiq/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmZnisYACgkQnvQgOdby
QH0CeA/+OC7atl0XQMjR4VQQqDbreN+RpgGA+vkvtQ6/Sn1rrAkdfhtbkXf0cxsV
zhoEY/iYFrAWWD/hf/KgNULBS+awjctnmF8a2zvyP+lMaSm+pCCjjdGqbHwr3PMB
64pTqE87sgzQKvNRg7h5e1wu9ScMRxjvdk/8JUmgzX48pl/05JhLKLoP33Uq57oq
KrvKTuwUAqui0Elpmu2O8Old46rhBDTtbawvAHEmWcWZSpjdKy7DI59LgsT65YZ+
W+s/ZslnXsBKRJ9sK84y7moc+9U+Nyj01K6dHNvShqPdh878AAgThrIHy2INGiSS
LTSDas2dqee8DzyqUSWzjt6RxFLaftlg3HarwciskyzUK04wo12JEE27lumvElhq
2mLdn3Ljcs8Z5REenA4mL8VsW4J3y2KJ7F1z6YtUhm3U+ZBv8vvikWoJVPGfrpC+
VzyYD4GeWlz4GUuHrUltpqQ6eHEL4O8XdUuyjEeQpSFQWZjeMywv02vi2QCU0rG5
ieyIIAZQGlOv+keDEFsPHMpSTs7H2a1kn3/1Eb1EbcrCXFY2qpIosbCH3eV7wp6I
cImzE3RzQ2727P2crZACgaZO2IgkAfH8SaE+SjvTXlwSY6xJ0uUdLMHXJpT+8/V8
kpgTAFunfp9X4x6f9AdaEc/gKeSCaN8UEjuzj+WX0kdzuxgbHLs=
=JhJ4
-----END PGP SIGNATURE-----

--42472DpttqMhOiq/--