Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sJHD7-0042mO-N4 for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Jun 2024 18:36:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sJHD5-002fHr-HQ for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Jun 2024 18:36:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sJHD5-002fHj-77 for pgsql-hackers@lists.postgresql.org; Mon, 17 Jun 2024 18:36:08 +0000 Received: from mail-io1-xd36.google.com ([2607:f8b0:4864:20::d36]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1sJHD3-002A5T-9g for pgsql-hackers@postgresql.org; Mon, 17 Jun 2024 18:36:07 +0000 Received: by mail-io1-xd36.google.com with SMTP id ca18e2360f4ac-7e21b6e98bdso180820139f.0 for ; Mon, 17 Jun 2024 11:36:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718649363; x=1719254163; darn=postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UxmwohkXHZf2FZOl5Tfpz8h3SPyEch9qqvMychWKfXw=; b=BliOI/r//IpDvJ6/3uLYdH0wDhKfLu037AWxTgrFIWthC1qD8oStqtFP13ijtR+g3F aMnPYx3UU2+QYr8dpcLbYOSsXLd+9Gcr7jNQZzz70snJm2urDRhzUkmDGof7P/3FKNxh OXtTDzTEQbON5HK8/WrlsNyGGx8M3ZmbJUvyb3Mj68vK5pQee31ZsNn7n7SoaXPN+ezf FmT1W8W4OfE8C5XDJbOC8I/ZxJLE8/zYzgRniXUrb77xqXU5dpi1Biwr1vuguu9d660j SgUK1O2xtX/aWRVprok8NcYHj27NGMqvwRHkw1pq7Z4OqsGasfULN1JgJMOrcUuW96hJ 5ikQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718649363; x=1719254163; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UxmwohkXHZf2FZOl5Tfpz8h3SPyEch9qqvMychWKfXw=; b=faA/GA1hZJA9jnXNvPHdZ6GebmtdZIPjod0rsd22yiVCt4KxSPdvQb+SWcGekEU2MG fRoutsXka/XnR6/ymiszPA9eSHk8Fb5adVFlylz43nDLyC+sv6r/PV9doqmpCROIy0t4 q6XOfAWTCPqq94jAUndTn8tuB1zbuHrpV/pjDLS31J2mutPwzwxy25TsFvCz7g79fsHm fNsZ/UFk5y6vV5qHfhseQ4xUxYh6K8PJ9/GMMLpabfW6uerPj+me2t66eDzdNZPL0Y51 FBAfYHbM3WzvXEPimYKNwdcUDhlFff5pQvAiBc4QI8mD/A7or0ddTlB507xo4FLntF3E w4nQ== X-Forwarded-Encrypted: i=1; AJvYcCX/JMFzW2Ei0kDdEF7NwIqG8kJZvE2MZPrS02mKk8P5p9t/cp2CUpV0FTQcc9Y/F7Rbjnd82AVYbqrmJAUj1oqA3eSHyUsF3qkGbnwT X-Gm-Message-State: AOJu0YwgcIdEeAX2UkM9d9z72ZHFSxU5TryX+oggxFXrElsTAE0VYK7A rGfCXpg45Ed3Qcm3OT6ZljdKocmnAUg055c+jEMNHjmBXMyhBa85 X-Google-Smtp-Source: AGHT+IHgvfWsP0gF2/MYPNXRmKdaCejOnMrCmQcKcW8oHzw370zJK2CStyeNSP+wmcBphWqLeP7gRA== X-Received: by 2002:a05:6602:1545:b0:7eb:6be7:2e6e with SMTP id ca18e2360f4ac-7ebeb4975f4mr1058000239f.2.1718649363029; Mon, 17 Jun 2024 11:36:03 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4b9568ddeb0sm2724628173.3.2024.06.17.11.36.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 11:36:02 -0700 (PDT) Date: Mon, 17 Jun 2024 13:36:00 -0500 From: Nathan Bossart To: Thomas Munro Cc: Heikki Linnakangas , pgsql-hackers , reid.thompson@crunchydata.com, Robert Haas , Andres Freund , Tristan Partin Subject: Re: Refactoring backend fork+exec code Message-ID: References: <2136fb4f-1630-43e9-9cf6-b32772b4b0a0@iki.fi> <20240214213711.2gjlezqll37mg7lg@awork3.anarazel.de> <8f695109-8341-4f7c-8b0d-3cadc7eddc9e@iki.fi> <0c247a78-9dac-4584-8e87-39f2b45bec68@iki.fi> <861f42c1-01c4-42e6-ab2f-d5743ff69607@iki.fi> <53a0a952-1b58-4346-941c-6b767108963a@iki.fi> <47965166-073f-49c8-9e8d-fd6ba37c61fb@iki.fi> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3w25Vqy6I3CbET0Q" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --3w25Vqy6I3CbET0Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline While looking into [0], I noticed that main() still only checks for the --fork prefix, but IIUC commit aafc05d removed all --fork* options except for --forkchild. I've attached a patch to strengthen the check in main(). This is definitely just a nitpick. [0] https://postgr.es/m/CAKAnmmJkZtZAiSryho%3DgYpbvC7H-HNjEDAh16F3SoC9LPu8rqQ%40mail.gmail.com -- nathan --3w25Vqy6I3CbET0Q Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="forkchild_check.patch" diff --git a/src/backend/main/main.c b/src/backend/main/main.c index bfd0c5ed65..4672aab837 100644 --- a/src/backend/main/main.c +++ b/src/backend/main/main.c @@ -185,7 +185,7 @@ main(int argc, char *argv[]) else if (argc > 1 && strcmp(argv[1], "--boot") == 0) BootstrapModeMain(argc, argv, false); #ifdef EXEC_BACKEND - else if (argc > 1 && strncmp(argv[1], "--fork", 6) == 0) + else if (argc > 1 && strncmp(argv[1], "--forkchild", 11) == 0) SubPostmasterMain(argc, argv); #endif else if (argc > 1 && strcmp(argv[1], "--describe-config") == 0) --3w25Vqy6I3CbET0Q--