Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 26 Jun 2024 14:39:57 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Fix possible overflow of pg_stat DSA's refcnt
Message-ID: <ZnuprZeVZd2X_MOD@paquier.xyz>
References: <CAO6_XqqJbJBL=M7Ym13TcB4Xnq58vRa2jcC+gwEPBgbAda6B1Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ClmJxpeNE9RCu9j0"
Content-Disposition: inline
In-Reply-To: <CAO6_XqqJbJBL=M7Ym13TcB4Xnq58vRa2jcC+gwEPBgbAda6B1Q@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZnuprZeVZd2X_MOD%40paquier.xyz>
Precedence: bulk


--ClmJxpeNE9RCu9j0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 25, 2024 at 05:01:55PM +0200, Anthonin Bonnefoy wrote:
> During backend initialisation, pgStat DSA is attached using
> dsa_attach_in_place with a NULL segment. The NULL segment means that
> there's no callback to release the DSA when the process exits.
> pgstat_detach_shmem only calls dsa_detach which, as mentioned in the
> function's comment, doesn't include releasing and doesn't decrement the
> reference count of pgStat DSA.
>=20
> Thus, every time a backend is created, pgStat DSA's refcnt is incremented
> but never decremented when the backend shutdown. It will eventually
> overflow and reach 0, triggering the "could not attach to dynamic shared
> area" error on all newly created backends. When this state is reached, the
> only way to recover is to restart the db to reset the counter.

Very good catch!  It looks like you have seen that in the field, then.
Sad face.

> This patch fixes this issue by releasing pgStat DSA with
> dsa_release_in_place during pgStat shutdown to correctly decrement the
> refcnt.

Sounds logic to me to do that in the pgstat shutdown callback, ordered
with the dsa_detach calls in a single location rather than registering
a different callback to do the same job.  Will fix and backpatch,
thanks for the report!
--
Michael

--ClmJxpeNE9RCu9j0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmZ7qa0ACgkQnvQgOdby
QH1d2w//QYD54tCYTXmOlT9oMG0IFPd0A+YNvhuX8qsW2oEtQicphBCv8djV/xta
eWn4hVtMAtZJ7ZFWBCdHqBoV9whYmGsS5SuLXhWdqlTHWch9P8X+spR8WUGWuHT1
EFW3VdOf2py5S5fvFdv7lNh+ByieFfLQgOgmDfeqDsXHS1AyOlSEbXwHrSFvSNKx
dq+zjRj1B01gaM2QFtPCHug4jV4jP5rCch6hx1RLaRdqtsU4jq8nzdJsGJo7x3Ic
IDpDqJz6koD40DKCAd5ynwNGn3C/Z0H1EeA1zMfuM/c0OmR+MPxRLi4+XubR5vCf
IVUOEDxCoy3+g+PIvK4X3vK6jqmhhtha0lwOv/RIRxO2Z12NODqFFtfc9bXght7g
lm1PnISvEeXFn3OCAiFA7EVzYPpXwFJyoencAOewVlU0D6A9M2TSb4OBdgmuXiG9
bdkaxtvJEFy8gmS4IwEn1XkBlLPDBlGlbDixA+XoeQq8hD1cGxUM2xF6a5gkthT0
7g4E1gW1R0+rHtfV4R+wzqmd8g8Oxy3jaNY1GlQnpNKKjjsk91PpkIe16rCF0KSb
lpllcwDRzNpERfwN9EhDAF7Kv7cRM7og1rL+FdE570WyV2RwWj0WDKxUfvVGA/bH
CKA69pQPXxHfCEGeBpn1wjqSUc8ulMpKMfCIVjONj15Nx13J7Sg=
=oxao
-----END PGP SIGNATURE-----

--ClmJxpeNE9RCu9j0--