Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sMgNI-003q7j-As for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Jun 2024 04:04:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sMgNF-0084ld-Uv for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Jun 2024 04:04:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sMgNF-0084lV-LU for pgsql-hackers@lists.postgresql.org; Thu, 27 Jun 2024 04:04:41 +0000 Received: from fhigh6-smtp.messagingengine.com ([103.168.172.157]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sMgND-003KPX-AL for pgsql-hackers@postgresql.org; Thu, 27 Jun 2024 04:04:40 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 800F711402E0; Thu, 27 Jun 2024 00:04:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 27 Jun 2024 00:04:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1719461078; x=1719547478; bh=Vkhy1Nm8vy G0sQYeZfKwblLc0UAaS+g69apqTuJG2aE=; b=hUbp7ORkmwQZccSAGYOMV0pZKW yzZpBnge8PBfOAbqGJRx1whJtiDTyq1jx05JGzzFMgAVrNUn6arHdFvHYbkDkFfS rEjsbnzFvGhQ6fOUvslfHyB59dtyrUwQOhJle+280155D4ZQ0KttUUShBAwu1Gkw i/07/rKZZVAPgtCbpbwwSzWdgYu2O/QBxlffAToD6wPzUVa61QDeVRgVbWONjPVr RA8SnP9DLvTqxQ46f59zNhcAiuO6PckIhK/f9aBaOH9aisLMDjZ8o3et+bZ9TOi1 U9HnyLg4qqIsGCgxAALMHRP28fBV7hsUsmjgceGKU/Y6DXBfVwIkNO3wGx8A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1719461078; x=1719547478; bh=Vkhy1Nm8vyG0sQYeZfKwblLc0UAa S+g69apqTuJG2aE=; b=KMS5Ak6npKX1cW0fZYMynyzujNERgSKTtNtS7yVNFMBS IxA8sYLtn5IdWxFQ1I9Zb6TQ3CSxQviBT+sTS0v5veAPWw/wVfQKe9IyTaHJ76Oy AIke6XvSltgHuwLBoHGWr1ZXct1ur9ISI5RQA0iMawo0C8m9LsNHkl11RS5JI0Hb cHg0Iem4LnYUFlsuUh40WZRt7/XaWyKUrrAHSJZ6xmC8uCoh4JICrs6WqYgSw7Kl OYh3zl8N0AuTeIjEr7AKfWsqc9sVkbW8FPZBkOt6s600By2Rej1cuRDNLdnA+sSx /TTVMc7xREwbPDNcCyy3FJzWdTuP7Kwi2NYOau9czA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrtdefgdejlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeg geffhfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 27 Jun 2024 00:04:36 -0400 (EDT) Date: Thu, 27 Jun 2024 13:04:22 +0900 From: Michael Paquier To: Yugo NAGATA Cc: Ranier Vilela , =?iso-8859-1?Q?Fabr=EDzio?= de Royes Mello , Pg Hackers Subject: Re: Avoid incomplete copy string (src/backend/access/transam/xlog.c) Message-ID: References: <20240624122728.95d555f1358547a75abebd85@sranhm.sraoss.co.jp> <20240627121704.57222340fd1ca2c0256c3340@sranhm.sraoss.co.jp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ffvJjoroF60DBJLs" Content-Disposition: inline In-Reply-To: <20240627121704.57222340fd1ca2c0256c3340@sranhm.sraoss.co.jp> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --ffvJjoroF60DBJLs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 27, 2024 at 12:17:04PM +0900, Yugo NAGATA wrote: > I don't think it is better to show a string longer than MAXPGPATH (=1024) > in the error message. +1. I am not convinced that this is useful in this context. -- Michael --ffvJjoroF60DBJLs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmZ85MYACgkQnvQgOdby QH3Q4w/9F84Mtw0a9r62AkFug30JLLSOr9acKXZn0u5Z5/LcvKcYPEg+wUF+ANvf HIRcOyrJPkbJm2lryNHxx/IFYQ9uR7xfIc8mxZvcpigq3uoVBqgh0wajU/Oi/dFS u5I3u8x5Si4Jz9obWb0p5nyVwhF6TdT7s4NnBtDmsT70W7jI/lhFP0OE8yVGr1+Q +pyapFbYnWbjLZie+A6PMHeFYsEZNjN/3KjsUF1WybUzF20Se0b52+Ov/Y2UVGag nF7b0QFP42G/fB3QIiFa8JRBT7LgQh+K7F/y7dLd18XE6fm24qT7UG/CDEOHCb1L /yDgCVkSOw38XXN+ShI5ca3cSiZKX9dC+ewXpa9mi76xDdikud9P3J7PeTF+1mqj PYS7Whz7/xqqOV/H73LofVAq8g41bchJLlszPq9/tdx95MfeMp1EbbAmBnAFQ7JU ium9h0uTICy9ZgU3bFCzZixKygUfR5HplCAAIU21znaFGwQDnfdEcMiUK2meC2Sj GK9xLDSUillgvvrUMrBKLPy5bUhGs7HOP++EolUSqoejR6l1oI/pd1KszshYL9vy Is7PXV71advO4dQ3cggxdSCtWdGw9Wg2ThkDenLrUKVcW3qHhhqTLCsXXSLJEi76 Bv1VyB7Z7VwljWrGMlE/lPQVgiZrtF1S4axq0g+XsyYlY/WeT7s= =Bue4 -----END PGP SIGNATURE----- --ffvJjoroF60DBJLs--