Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 10 Jul 2024 13:16:15 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: "Andrey M. Borodin" <x4mmm@yandex-team.ru>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Injection points: preloading and runtime arguments
Message-ID: <Zo4LD044_H9aSLqQ@paquier.xyz>
References: <BF05D322-C71D-432C-8029-8315BEABA5A1@yandex-team.ru>
 <Zkv5XJci7e2jbyvk@paquier.xyz>
 <B0FAFD52-FB9F-452B-A370-25C69A397FA7@yandex-team.ru>
 <Zl-asNW0NUYd_MuF@paquier.xyz>
 <F5CA5FD7-4731-4663-8A05-8B641CF11CA6@yandex-team.ru>
 <ZmJIhkc73nvFNEUS@paquier.xyz>
 <9ED3A789-0516-4781-87C1-5BF966D681EE@yandex-team.ru>
 <ZmaY2W_ZWHlma2Ln@paquier.xyz>
 <Zoe54pHExN-USTpy@paquier.xyz>
 <58d588d0-e63f-432f-9181-bed29313dece@iki.fi>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="oMz9423kX72+0Fqn"
Content-Disposition: inline
In-Reply-To: <58d588d0-e63f-432f-9181-bed29313dece@iki.fi>
Archived-At: 
 <https://www.postgresql.org/message-id/Zo4LD044_H9aSLqQ%40paquier.xyz>
Precedence: bulk


--oMz9423kX72+0Fqn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 09, 2024 at 12:08:26PM +0300, Heikki Linnakangas wrote:
> And the injection point is attached in between the INJECTION_POINT_LOAD()
> and INJECTION_POINT() calls, you will still get an assertion failure. For=
 a
> testing facility, maybe that's acceptable, but it could be fixed pretty
> easily.
>=20
> I propose we introduce an INJECTION_POINT_CACHED(name) macro that *only*
> uses the local cache.

You mean with something that does a injection_point_cache_get()
followed by a callback run if anything is found in the local cache?
Why not.  Based on what you have posted at [1], it looks like this had
better check the contents of the cache's generation with what's in
shmem, as well as destroying InjectionPointCache if there is nothing
else, so there's a possible dependency here depending on how much
maintenance this should do with the cache to keep it consistent.

> We could then also add an assertion in
> InjectionPointRun() to check that it's not used in a critical section, to
> enforce correct usage.

That would be the same as what we do currently with a palloc() coming
=66rom load_external_function() or hash_create(), whichever comes first.
Okay, the stack reported is deeper in this case.

[1]: https://www.postgresql.org/message-id/87c748b3-0786-490f-a17a-51bef63e=
6c7f@iki.fi
--
Michael

--oMz9423kX72+0Fqn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmaOCw8ACgkQnvQgOdby
QH3SJQ/+L/L/vJuH2uIBr/LlO854QH2m6eA1qnSS70PPpMyg/0VUbtywT8F8+Bhj
MzVZx2MlSI8vgLaUmwTQ3x2536Jmn04TQjGZylvWdUq6gZJH6e/9czDgnA93nk5e
pJI4RjIxDavT1lViAVNkKghVftklICQQDRAOxatG1v9aMxdqZ7j1xDqFQYkToI9u
kzM22x7lIRPNBsDIrJXo3bIRDt2MUmTpEE2ccghEkIkDAMwX2DyYfpTYOqoSA9OD
qGanmI812pxla6xA0Vqn+ZSKtZhE/lHITu/5yOe0InaPBouDrrK5BHwuJ+FgX4Gb
gnHd9KPBtP6QbK+8Jls5C3SVPIhc/mDAJ+TcNIde37pOE4oBBOvEqD2W05oKm6MH
BjlAf0EfWmxzFSdCRZC+Q9QNAeGWV2VN1NdFB+BcXeaOxZJzlWpW+0RSQdjq6Nlg
6LWPgX3dDhYFVgJauwyoaNRGqVJO/7iK4qx1dnYDw33xuK8oi3+pPQ+zDupa8jfg
H4U1inWgLyXYe6MHO93yIS1Kb7MyeeSkFbIWYhZO7eJj+WHBmjSV/SzQK8Ar+h4M
seBP/HUw6zga7ID1fj/mlE0GAhEhC9TVVdTWdn6jqCogcT8Y3puj4oSO0xxpIrv6
dgxcQn69UO+sVLvsgasw4/22AyJYd3DHo5LtSwIqI68fAtLTsRY=
=Rkl0
-----END PGP SIGNATURE-----

--oMz9423kX72+0Fqn--