Date: Thu, 11 Jul 2024 06:10:23 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: relfilenode statistics
Message-ID: <Zo93T63yVkDcKw3P@ip-10-97-1-34.eu-west-3.compute.internal>
References: <ZlGYokUIlERemvpB@ip-10-97-1-34.eu-west-3.compute.internal>
 <Zo4j-mC0Ps3vnjZ4@paquier.xyz>
 <Zo6OvsBLUbYm6nQM@ip-10-97-1-34.eu-west-3.compute.internal>
 <Zo9j69GhexDpeV4k@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zo9j69GhexDpeV4k@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/Zo93T63yVkDcKw3P%40ip-10-97-1-34.eu-west-3.compute.internal>
Precedence: bulk

Hi,

On Thu, Jul 11, 2024 at 01:58:19PM +0900, Michael Paquier wrote:
> On Wed, Jul 10, 2024 at 01:38:06PM +0000, Bertrand Drouvot wrote:
> > So, I think it makes sense to link the hashkey to all the RelFileLocator
> > fields, means:
> > 
> > dboid (linked to RelFileLocator's dbOid)
> > objoid (linked to RelFileLocator's spcOid)
> > relfile (linked to RelFileLocator's relNumber)
> 
> Hmm.  How about using the table OID as objoid,

The issue is that we don't have the relation OID when writing buffers out (that's
one of the reason explained in [1]).

[1]: https://www.postgresql.org/message-id/Zl2k8u4HDTUW6QlC%40ip-10-97-1-34.eu-west-3.compute.internal

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com