Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 2 Jul 2024 10:18:59 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Peter Eisentraut <peter@eisentraut.org>,
	Soumyadeep Chakraborty <soumyadeep2007@gmail.com>,
	Zhihong Yu <zyu@yugabyte.com>, pgsql-hackers@postgresql.org,
	Ashwin Agrawal <ashwinstar@gmail.com>, vanjared@vmware.com,
	Alexander Lakhin <exclusion@gmail.com>
Subject: Re: ALTER TABLE SET ACCESS METHOD on partitioned tables
Message-ID: <ZoNVg33etJOKmCeL@paquier.xyz>
References: <202403261105.6o4ff4d6qagc@alvherre.pgsql>
 <202403211207.hfyirjweshbh@alvherre.pgsql>
 <ZgNSQraRJ4vWe6KI@pryzbyj2023>
 <ZkyivySXnbvOogZz@pryzbyj2023>
 <ZmEGMz7TC8SOIUpn@paquier.xyz>
 <ZoNId8GifUS4TlgG@paquier.xyz>
 <2969207.1719880817@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Yc1Jx3YQhTVbas9A"
Content-Disposition: inline
In-Reply-To: <2969207.1719880817@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/ZoNVg33etJOKmCeL%40paquier.xyz>
Precedence: bulk


--Yc1Jx3YQhTVbas9A
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jul 01, 2024 at 08:40:17PM -0400, Tom Lane wrote:
> While this won't actually fail against a v10 or v11 server, it won't
> show anything useful either (because relam is zero for heaps in
> pre-v12 versions).  Perhaps there should be a check to only add the
> extra column if server >= v12?

I've thought about that and would be OK to restrict things with this
suggestion if you'd prefer it.  However, I could not decide in favor
of it as using a psql \dP+ >= v18 gives the possibility to show the
AMs of partitioned indexes, as these are also part listed in \dP.  So
I've found that useful in itself.
--
Michael

--Yc1Jx3YQhTVbas9A
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmaDVYMACgkQnvQgOdby
QH0P5w/7BfzC8HIeZlWgF3XEF40Rm1rvFKtFLNOgHHGygRGr0wXrPAStHtM+lEwv
W533wDtjT2e12UmERgcUyiKOLN2lC65AqI2bnuuT5OzioFOcrZ9BhqAkWB5DcL/3
K8Sn3M+W/F0WIPp30aZ+ewOJYwL0IQzriYzIRT7m0yIVbqCwoWa83crC8bt38iGA
i/szXy1tCDgueXX8780IczPUkWpFBDAFBjJF9hckGuzkzG53t/u+n11poUp7N9w+
a+qfiZOM2jHJaaGumSVBN8gk1bevA709j02lYHwv4Mp+gu1gyQiswWLHEuZpX79Q
0xc7nlSmsQWb+TDPWIRmbwyUTMCHHFNjswdnhekGKz0tAWJCk1x0gJFdQ6FngXrF
JNOCX/OKZg76jaKzDLak4wG8+eNzEM8wygDDuk8DdnqViCKgmxANOxV5HqRaNYdJ
mPJ9X809idGEEThXykFB+5yR83VE6sBEJb8YIRo6cI9q6JZb0YES9BjmC8dO6dXE
2ufT/kl/1vwr5aMF97RqoZ4P55Exfhyl+JoaO7EAswm+JWokxt6BxiLyi82HcAuX
VgSEz9/hxSWnrL8NRe1du1/aSUH6bNB+42pgY60+TInyLERTwHsvKvFXp5FXXy1X
w28CZLc4Uznv3LLyZ/8Bv5QlV2gpT9oMMGyiAMo9JWThu+ssjkg=
=DMYK
-----END PGP SIGNATURE-----

--Yc1Jx3YQhTVbas9A--