Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 12 Jul 2024 09:01:30 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Ilya Gladyshev <ilya.v.gladyshev@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
	Alexander Pyhalov <a.pyhalov@postgrespro.ru>,
	pgsql-hackers@lists.postgresql.org,
	Masahiko Sawada <sawada.mshk@gmail.com>,
	=?utf-8?B?IuadjuadsCjmhY7ov70pIg==?= <adger.lj@alibaba-inc.com>
Subject: Re: CREATE INDEX CONCURRENTLY on partitioned index
Message-ID: <ZpByWlw0nJ1I_qr5@paquier.xyz>
References: <ZK9hLNhTMXFcAcRG@telsasoft.com>
 <37d3f0a984a15f6465b83027eed8c588@postgrespro.ru>
 <efd4febd4ed08e579318de59e16e087c@postgrespro.ru>
 <8fe0027c-a4f9-43a0-afc1-20362c159d07@gmail.com>
 <a86b4d57f83c85519cc25431e9249f28@postgrespro.ru>
 <76a11eea-c5ae-4034-971d-c8a2df0bb14d@gmail.com>
 <df5e91946320d4c3aade07898d4ba728@postgrespro.ru>
 <55cfae76-2ffa-43ed-a7e7-901bffbebee4@gmail.com>
 <Zo_QneIgShh7zrKn@pryzbyj2023>
 <5F602655-58E6-4562-85D3-34E04BE9D60C@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="c3Rt7b6BhTIT3lXn"
Content-Disposition: inline
In-Reply-To: <5F602655-58E6-4562-85D3-34E04BE9D60C@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZpByWlw0nJ1I_qr5%40paquier.xyz>
Precedence: bulk


--c3Rt7b6BhTIT3lXn
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 11, 2024 at 09:35:24PM +0100, Ilya Gladyshev wrote:
> It is broken in master, I just didn=E2=80=99t want to create a separate
> thread, but it can be fixed independently. As I remember, the
> problem is that progress is tracked for each table in the hierarchy
> as if the table is processed separately, without ever setting
> partitions_total and partitions_done counters.

Please let's move this point to its own thread and deal with it with
an independent patch.  Hiding that in a thread that's already quite
long is not a good idea.  This needs proper review, and a separate
thread with a good subject to describe the problem will attract a
better audience to deal with the problem you are seeing.

I was not paying much attention, until you've mentioned that this was
an issue with HEAD.
--
Michael

--c3Rt7b6BhTIT3lXn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmaQcloACgkQnvQgOdby
QH02Eg/+LJe8O3v2B+egKEXuGFxGRJHk+ysT4aSwtWnNmpCgc8qEHdqSvqzAmtuZ
9nowDCFibWJ7a82cTvh10f/UKXu+D/zvwOlccd2eywsI2QwmEkaQNVRT/25y6M5+
fuMB1ujpRzzyazM8a6lpTQ1fkN7uKY+LSBSGwTJ0gqdUUEUnQvaGnFCT7eFOV6Vp
HDVqsRbR65tyATa9T79RIjuz9hicOoRSO5SL1RZ07tpwKhbojfY3PydyOKBlgeVe
D2jI66CH/TWbicMXPpBnp89INTmsNoTnd6oQyII1LJ3paQO3Rl6dSnGO4J825Kag
MSMjiUxUbLjSJUuUETxIUpjlLd2CNM7S+b2uZh+r5XyqkwnjSBVNGgUuGAmMEhWG
rsdshttUDIgVPMwVGAMNew6XvnZzGoRKjt/W5xW2Ie1K+kpey5EIWE4a8El3BO0b
KTcOc6zmctqVG4R+oA5RtToQo9r4GpkRWQUcDaDXToH7m7h1o+y/CQ2d6D3g8PnN
3hn9dZLmAluYlP9lHwudxXJ28HwRqYaKN/efKFr55733lSJbkxyC4IrVLctrikqR
g+GKgHC1HLQPp/1iUQr/IyBL39foyCDuq5XXpH569N4jp0OXMSb+5MsiGrYznkIp
v/LPNnzDsWaCFhM5IcSuxuinbSrj3GDgbjxDjMkE4wMrgDl3MP8=
=DHWu
-----END PGP SIGNATURE-----

--c3Rt7b6BhTIT3lXn--