Date: Mon, 15 Jul 2024 12:14:47 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Erik Rijkers <er@xs4all.nl>, pgsql-hackers@lists.postgresql.org,
	Thomas Munro <thomas.munro@gmail.com>
Subject: Re: gcc 12.1.0 warning
Message-ID: <ZpVZB9rH5tHllO75@nathan>
References: <a74a1a0d-0fd2-3649-5224-4f754e8f91aa@xs4all.nl>
 <CAN55FZ25T4Y3iYFpGp_DJagvQ7mVrgeYXfmJwCCtXeA1Frho-A@mail.gmail.com>
 <20240413022547.yhhr6r4pgwpnx7w3@awork3.anarazel.de>
 <CAN55FZ2iCN7e+1w=zBoCfQ85ToKuRENbFJQP9fTo28rS=gyHjQ@mail.gmail.com>
 <20240423165939.7tm2lthmuofzmcdq@awork3.anarazel.de>
 <CAN55FZ0o9wqVoMTh_gJCmj_+4XbX9VXzQF8OySPZ0R1saxV3bA@mail.gmail.com>
 <20240715164155.7blp2h6j4spc2ha4@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240715164155.7blp2h6j4spc2ha4@awork3.anarazel.de>
Archived-At: <https://www.postgresql.org/message-id/ZpVZB9rH5tHllO75%40nathan>
Precedence: bulk

On Mon, Jul 15, 2024 at 09:41:55AM -0700, Andres Freund wrote:
> On 2024-05-10 12:13:21 +0300, Nazir Bilal Yavuz wrote:
>> The fix is attached. It cleanly applies from REL_15_STABLE to
>> REL_12_STABLE, fixes the warnings and the tests pass.
> 
> Thanks! I've applied it to all branches - while it's not required to avoid a
> warning in newer versions, it's still not correct as it was...

nitpick: pgindent thinks one of the spaces is unnecessary.

diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index a043d529ef..b0947a4cf1 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -1289,8 +1289,8 @@ find_option(const char *name, bool create_placeholders, bool skip_errors,
 static int
 guc_var_compare(const void *a, const void *b)
 {
-    const char *namea = **(const char ** const *) a;
-    const char *nameb = **(const char ** const *) b;
+    const char *namea = **(const char **const *) a;
+    const char *nameb = **(const char **const *) b;

     return guc_name_compare(namea, nameb);
 }

-- 
nathan