Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 18 Jul 2024 13:26:29 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Joe Conway <mail@joeconway.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>,
	Gurjeet Singh <gurjeet@singh.im>,
	Masahiko Sawada <sawada.mshk@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: RFC: pg_stat_logmsg
Message-ID: <ZpiZdR4m2KVi4RsC@paquier.xyz>
References: <89742024-d51a-c66b-90b9-67f837072cd2@joeconway.com>
 <CAD21AoAyPVYZ_6VAQCOanvHTL3CRSqTDCFrtvaYVGwOQbrnxgQ@mail.gmail.com>
 <CABwTF4VzMJaTLrpYtBj4n9r73TFjffzqpPFeUmJPrkY6cmHEAg@mail.gmail.com>
 <3b1683bc-2630-a0d0-6083-8a45aa1b54bf@joeconway.com>
 <cda17e6d-f625-b45e-dfb9-8d18ed09ecc5@joeconway.com>
 <5dc12198-80ff-4e70-b187-11ef33418411@enterprisedb.com>
 <Zpb9gBjB2FfiD8jO@paquier.xyz>
 <adb2f669-7c18-4924-a29a-d7e20e95a0f4@joeconway.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Zw9s+NVV752oIikv"
Content-Disposition: inline
In-Reply-To: <adb2f669-7c18-4924-a29a-d7e20e95a0f4@joeconway.com>
Archived-At: <https://www.postgresql.org/message-id/ZpiZdR4m2KVi4RsC%40paquier.xyz>
Precedence: bulk


--Zw9s+NVV752oIikv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jul 17, 2024 at 07:48:15AM -0400, Joe Conway wrote:
> I think including version in the key makes most sense. Also do we even have
> a mechanism to grab the commit sha in running code?

Not directly, still that's doable.

The closest thing I would consider here is to get the output of
something like 'git rev-parse --short HEAD` and attach it to
PG_VERSION with --with-extra-version.  I do that in my local builds
because I always want to know from which commit I am building
something.  Then, PG_VERSION could be stored with the entries while
hashing the stats key with the version string, the error code, the
source file name and/or the line number for uniqueness.  32 bytes of
room would be most likely enough when it comes to the PG_VERSION data
stored in the stats entries.
--
Michael

--Zw9s+NVV752oIikv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIyBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmaYmXUACgkQnvQgOdby
QH1y1Q/3euKfAUkj2RuctriTLDrSKeDiP6JyRpgbcoMAc9KrIfh23aEZfO2EhFES
4ecGbhGk1mSsYsQMe6qwJfuBJlPmf+YlAcG3m/XuH4dmMVbqBBNhi0By5tXHML1T
xzJHrvsJYVzvnoKtfQ6GkuBKOpVDT6hcXALiSGftROQkHbICsHGsZDcER8paelih
1z7smaRje98e/kPHtnu9dQN7G+EOPOIAs3+hg1kkyY5aO0MtLjkm/oVlumHn0dOM
BDE8Ckx96ycPLKDeOoB5U/1ixdFM8KVj9Jpy+nW7tZ6fYVC15bAFoett3j+uNYLj
rswXOwD0Cfqa+Mx1U0qXyd/Pow9EuHnn6mrM7BQinBushnfT8v3UBvoJDfP5r0Gt
HPOaoERKQnsGkTeMpDs7g3+7nGyW7aukR892XFvloh8v51LwB1TJDmIpJfKYF1o/
neSaR9O5Bgjm72O2KFGTCn9TqiCf7cdMxpiOzCYkcALx/YSHhnSRe9d2CCvV41v7
DOuXKku8vPUCRt5Lyv2MvXAn9yf4Og8LaHj/gYNIN0YzIrK76f3gHwXjrhFHkGHX
bN/tAs80rW1a3bpU3an8HtThpiqwPNEkMHet2OFuIkU3b6zYKvcAo3/rw0O/iYwq
jyJb1BpFYSxYBkxGVWo9RMMdApBN4NI4ES+thrssJbRuZkF+Bw==
=FZvg
-----END PGP SIGNATURE-----

--Zw9s+NVV752oIikv--