Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 19 Jul 2024 09:13:11 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Correctly propagate queryId for utility stmt in function
Message-ID: <Zpmvly3YGDH6OWGz@paquier.xyz>
References: <CAO6_XqrGp-uwBqi3vBPLuRULKkddjC7R5QZCgsFren=8E+m2Sg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="MEpckU5oQPd8i7jP"
Content-Disposition: inline
In-Reply-To: <CAO6_XqrGp-uwBqi3vBPLuRULKkddjC7R5QZCgsFren=8E+m2Sg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Zpmvly3YGDH6OWGz%40paquier.xyz>
Precedence: bulk


--MEpckU5oQPd8i7jP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jul 18, 2024 at 01:37:40PM +0200, Anthonin Bonnefoy wrote:
> For utility statements defined within a function, the queryTree is
> copied to a plannedStmt as utility commands don't require planning.
> However, the queryId is not propagated to the plannedStmt. This leads
> to plugins relying on queryId like pg_stat_statements to not be able
> to track utility statements within function calls.

You are right, good catch.  This leads to only partial information
being reported depending on the setting of pg_stat_statements.track.
It is a point of detail, but I'd rather expand a bit more the tests on
top of what you are proposing:
- Upper and down-casing for non-top utility commands, to check that
they are counted consistently.
- Check with pg_stat_statements.track = 'top'
- Not cross-checking pg_stat_statements.track_utility = false is OK.

While this qualifies as something that could go down to all the stable
branches, it is much easier to think about utility statements in 16~
now that we compile the query IDs depending on their parsed tree, so
will apply down to that.

pg_stat_statements tests have also been refactored in 16~, but that's
a nit here..
--
Michael

--MEpckU5oQPd8i7jP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmaZr5cACgkQnvQgOdby
QH2mqg/9FFRXKz0Epr8/QgDlWkWyMNsOnYy49SX6r+vWuSc2X+LE3uA1FBf5s/nl
fB+BbABwyv40NqpjI7M09RJwLfHqWzpDyml2eyPB3wqrV9kvj06Pdx4l2VUVJmN6
wAI60o09LUPFa0EsO/nXPGJ8Y3F2L8RCFAw+op+5k5sArrbRt7UNVfdg3ImdmIVF
jyXYRdaYgUPplQaSgWXutax3Bf/ufk+3b2eYDCUMrwUny03GRh66IylH9KSGf6HQ
JYW+dzXwFkob7XG3iYE49JV++JjHXrra4YFqFPWtn6JXEHO/7qja9XRTQgIhf0/W
uhCnV34daOWZpJTLTdz2K14GirZVVP8LUa3gxwxf7pKUdHCyumYs/MJ4IG7U8KM+
VeAdcrERMB5lh9SNuaD1ce6P+ecLmIvhnOVuxQvlC13uC1oGN5BvLQMAy3xd4s0e
NDN88+10ubfYOsIdLBNjQqFcsLLcFTOZhfkVVYotGsQ4p3KKC+2NutIpq/4smES7
2/NV2vuphI9LoEkirPi7TXjpE2Gay0xUvgpAUKcBpQr/+rwtVS3/EOsXfK6WhkIN
OMw9QicG4w59nUCXs8BmPvT/zl7zX8RbsaEsmkt6DC2sBjbG2qyGf0smuaaPwMTw
800QD3lrtpSwg1u6h5GXUTQ7SaNORQRUulZH8uLHjnyeQoyM790=
=JfUW
-----END PGP SIGNATURE-----

--MEpckU5oQPd8i7jP--