Date: Fri, 19 Jul 2024 15:24:24 +0200
From: Christoph Berg <myon@debian.org>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Michael Banck <mbanck@gmx.net>, Tom Lane <tgl@sss.pgh.pa.us>,
	Nathan Bossart <nathandbossart@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Set log_lock_waits=on by default
Message-ID: <ZpppCLK1gNs7aXQS@msg.df7cb.de>
References: <b8b8502915e50f44deb111bc0b43a99e2733e117.camel@cybertec.at>
 <659ffa38.170a0220.eea6a.28fc@mx.google.com>
 <65b146b9.170a0220.c645b.0891@mx.google.com>
 <20240206165343.GA3841415@nathanxps13>
 <524751.1707240550@sss.pgh.pa.us>
 <6698edb4.5d0a0220.df6fa.5b59@mx.google.com>
 <5dc4e037f60467da7bf7d17b10f6ec632a7c9095.camel@cybertec.at>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5dc4e037f60467da7bf7d17b10f6ec632a7c9095.camel@cybertec.at>
Archived-At: <https://www.postgresql.org/message-id/ZpppCLK1gNs7aXQS%40msg.df7cb.de>
Precedence: bulk

Re: Laurenz Albe
> The major criticism is Tom's that it might unduly increase the log volume.
> 
> I'm not trying to rush things, but I see little point in kicking a trivial
> patch like this through many commitfests.  If no committer wants to step
> up and commit this, it should be rejected.

That would be a pity, I still think log_lock_waits=on by default would
be a good thing.

I have not seen any server yet where normal, legitimate operation
would routinely trigger the message. (If it did, people should likely
have used SKIP LOCKED or NOWAIT instead.) It would only increase the
log volume on systems that have a problem.

Christoph