Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 25 Jul 2024 17:55:19 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Ilya Gladyshev <ilya.v.gladyshev@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: REINDEX not updating partition progress
Message-ID: <ZqIS96vKtMR4g3o7@paquier.xyz>
References: <b72f2d89-820a-4fa2-9058-b155cf646f4f@gmail.com>
 <Zpnaz_gHMyf0xsso@paquier.xyz>
 <779baf7f-6fc7-4431-a08e-eec63d84c6a3@gmail.com>
 <18D00CB1-D34B-4B71-AC65-96F27D69A9D8@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="9RR6zJQ25pab3bss"
Content-Disposition: inline
In-Reply-To: <18D00CB1-D34B-4B71-AC65-96F27D69A9D8@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZqIS96vKtMR4g3o7%40paquier.xyz>
Precedence: bulk


--9RR6zJQ25pab3bss
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Jul 21, 2024 at 11:41:43AM +0100, Ilya Gladyshev wrote:
> Forgot to update partition_relid in reindex_index in the second patch. Fixed in attachment.

        <structfield>relid</structfield> <type>oid</type>
       </para>
       <para>
-       OID of the table on which the index is being created.
+       OID of the table on which the command was run.
       </para></entry>

Hmm.  I am not sure if we really need to change the definition of this
field, because it can have the same meaning when using a REINDEX on a
partitioned table, pointing to the parent table (the partition) of the
index currently rebuilt.

Hence, rather than a partition_relid, could a partitioned_relid
reflect better the situation, set only when issuing a REINDEX on a
partitioned relation?

+   if (relkind == RELKIND_PARTITIONED_INDEX)
+   {
+       heapId = IndexGetRelation(relid, true);
+   }
Shouldn't we report the partitioned index OID rather than its parent
table when running a REINDEX on a partitioned index?
--
Michael

--9RR6zJQ25pab3bss
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmaiEvcACgkQnvQgOdby
QH04dA//Xd8rV6F1Gcw+Wf5OEEqImiOQ3MqeOpqOn/VoFAonYhb+FZlMVGo0CFTl
zoSw+TQ2omdp5w8tSv2Q3gVCipCeTA7a7O/0znf3IHNEit4UOQu9oRs4UZ2AxXDS
zpqkgfIXCuu97u/5+IlUcI3OYvHm8f6+3eboDQGPKz9Hvw3/0aPSY1nnTRtWs1Ie
NgL2Dqb1XntdGV87irrrxXATufobHSareDfa+8B0ClmeLHzVFlo+2EqUTBOmwr+8
tlwA47duaKCtlS1UftizolDR3fiZHSYsQ0HqTNE42t0ANA+Rknmq704xAHBCgg0d
hHxcmW0vKLv5qJqJrgSSh0Tnq4bfrnthT3Ej7FTBUsVYguMTXrozbCe6824ryapB
Vek5qzcPI6jtlExHyRfIrUJyBTW94lQ3Nf/nYH4sCuFxQOT1dmKQlFhMu7T7itBH
+AgPQSDH65Vo2Dab7xxrWfWKNfc9JDgFgvt9WZrZ2obANuGEmf80gpF88tM6+jKO
Sx23j06n7cY7et/L0e7QlNzecwaF7fZedTmJb1conTEi/x814NqhHgS65v5uFSaZ
Z7DQd6axgiGDOc8d/W+qvyHtGT1jtoQx9Qy4qZa6Hlr3597jgAmcpG+7PJH2+awL
E3X4c891KoMOKjmjxUtAIzVlOip5REcxcsjKD1siSQlbDtnfgIM=
=juNy
-----END PGP SIGNATURE-----

--9RR6zJQ25pab3bss--