public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nathan Bossart <[email protected]>
To: Dagfinn Ilmari Mannsåker <[email protected]>
Cc: px shi <[email protected]>
Cc: [email protected]
Subject: Re: CREATE MATERIALIZED VIEW
Date: Thu, 25 Jul 2024 09:38:30 -0500
Message-ID: <ZqJjZscmd5TrTR36@nathan> (raw)
In-Reply-To: <[email protected]>
References: <CAAccyY+Wg1Z-9tNfSwLmuZVgGOwqU5u1OP-RWcoAr2UZGuvN_w@mail.gmail.com>
	<[email protected]>
	<[email protected]>

On Thu, Jul 25, 2024 at 03:09:09PM +0100, Dagfinn Ilmari Mannsåker wrote:
> Scratch that, I misread the diff. The tab completion has been there
> since matviews were added in commit 3bf3ab8c5636, but the restriction on
> unlogged matviews was added later in commit 3223b25ff73, which failed to
> update the tab completion code to match.

As noted a few years ago [0], the commit message for 3223b25ff73 indicates
this was intentional:

	I left the grammar and tab-completion support for CREATE UNLOGGED
	MATERIALIZED VIEW in place, since it's harmless and allows delivering a
	more specific error message about the unsupported feature.

However, since it looks like the feature was never actually supported in a
release, and the revert has been in place for over a decade, I think it'd
be reasonable to remove the tab completion now.  It looks like the folks on
the 2021 thread felt similarly.

[0] https://postgr.es/m/flat/ZR0P278MB092093E92263DE16734208A5D2C59%40ZR0P278MB0920.CHEP278.PROD.OUTLOOK...

-- 
nathan

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: CREATE MATERIALIZED VIEW
  In-Reply-To: <ZqJjZscmd5TrTR36@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox