Date: Thu, 25 Jul 2024 09:54:01 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= <ilmari@ilmari.org>
Cc: px shi <spxlyy123@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: CREATE MATERIALIZED VIEW
Message-ID: <ZqJnCV1pH99TUF7v@nathan>
References: <CAAccyY+Wg1Z-9tNfSwLmuZVgGOwqU5u1OP-RWcoAr2UZGuvN_w@mail.gmail.com>
 <87cyn1eft4.fsf@wibble.ilmari.org>
 <87a5i5ef7e.fsf@wibble.ilmari.org>
 <ZqJjZscmd5TrTR36@nathan>
 <877cd9edcx.fsf@wibble.ilmari.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <877cd9edcx.fsf@wibble.ilmari.org>
Archived-At: <https://www.postgresql.org/message-id/ZqJnCV1pH99TUF7v%40nathan>
Precedence: bulk

On Thu, Jul 25, 2024 at 03:49:02PM +0100, Dagfinn Ilmari Mannsåker wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> However, since it looks like the feature was never actually supported in a
>> release, and the revert has been in place for over a decade, I think it'd
>> be reasonable to remove the tab completion now.  It looks like the folks on
>> the 2021 thread felt similarly.
> 
> Keeping it in the grammar makes sense for the more specific error
> message, but I don't think the tab completion should be suggesting bogus
> things, regardless of whether it's the grammar or the parse analysis
> that rejects it.

Would you mind creating a commitfest entry for this one?  I'll plan on
committing this early next week unless any objections materialize.

-- 
nathan