Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sf0Bi-00FeaZ-3d for pgsql-hackers@arkaria.postgresql.org; Fri, 16 Aug 2024 16:52:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sf0Be-006XUk-P3 for pgsql-hackers@arkaria.postgresql.org; Fri, 16 Aug 2024 16:52:26 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sf0Be-006XUb-Be for pgsql-hackers@lists.postgresql.org; Fri, 16 Aug 2024 16:52:26 +0000 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1sf0BY-005Cj5-D5 for pgsql-hackers@lists.postgresql.org; Fri, 16 Aug 2024 16:52:25 +0000 Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-824d911b6c4so85072939f.2 for ; Fri, 16 Aug 2024 09:52:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723827138; x=1724431938; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kY26Ws3dbUR+Tbp8RL8h0jT1UbJ0lTzcesGoL2uP2pk=; b=nP2LhzVdlUSGtXSiSql9vUazWynoyB8qECOpLxQ3CMhMKCoiOi58D9REXMazWk0Y9o 5QsHVl8rurU2f/aqpCEASBj7HU5Tg+TB16c3B44q3i/cg6Dy6WiAjjBCGt0vgFtHaNNV BIjc8I8gfdMpbDcEY4UdHA1VhVBKQeagwY+3DnJemaKIa9i4p7KMif7054VgT9OQngdB /YmkbzXil9yfTBCmUNM99AuL/bGvgHv92PrJY6nhV1tx6jeeqTHbnGON17Hm8H7S5YeI XWM2/pmR9RFg4IXMoxlZV8jeUHykWQwwkjsRJO3WEMN1AaKHXI04iMm2Y01w01+V5Orp 73xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723827138; x=1724431938; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kY26Ws3dbUR+Tbp8RL8h0jT1UbJ0lTzcesGoL2uP2pk=; b=FVuhoNnVp0rdDET0vA2dKAoWHSMLpA/z2UN3NfKgDDEtjyLh5uXmCELfca2pVLZF/e 2SxbCSlUCBedvl2qkj3ZX+3dVEEGmWtZ1zTBurDXXMnoaSavOO9G3HID2/vZzUXmjSae fJWwSzRAWSvJSLH7eCVFhCIrmhP+qLnqfodnG2mAkAoZD8Vprbm9TVwKvElUULMhw785 0YnsdUX0xeBi99nIKBHSAHZbUsJbM6OY53UzdWOvSTDAjxJCiqkDSCiGLMF6df6YPGQy CauCiLGFuCjIxxVWr8Dc/XOGYDBpksAS6gbhcggs+pvXgKb7FCVSHJQgnNy3NTPR1YS2 xfLw== X-Forwarded-Encrypted: i=1; AJvYcCVQmP2CqcKHMP/yOQclKUAN1UR3dFORNUq9eMErw59VpV9hlkX/uAZAjBnPEinkZdkD5rBFwHiDLmCdQQx8YulFaYdYXg3leDFkxzwwghhYlsQB X-Gm-Message-State: AOJu0YzpFSEgJTOHPWZlR03/EtInqiNAq/wN7WVWSgIEzpfcyzaIJ6S/ Ugt11kx6T1L9aFTVXqS4aYm2XEdUyI6sAUwLN36h1lS6cKt7vQp8 X-Google-Smtp-Source: AGHT+IEIHO/s91BPxkQjVg2n6ZMZ3eSSj4mEw0iMSKaeNgSvl/uRiLkZHhfOLWybhj2TculW7oEm7w== X-Received: by 2002:a05:6602:13c8:b0:804:2216:4b23 with SMTP id ca18e2360f4ac-824f271ec38mr535575939f.17.1723827138361; Fri, 16 Aug 2024 09:52:18 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-824e990e304sm133983839f.20.2024.08.16.09.52.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2024 09:52:17 -0700 (PDT) Date: Fri, 16 Aug 2024 11:52:16 -0500 From: Nathan Bossart To: Joseph Koshakow Cc: jian he , Heikki Linnakangas , Matthew Kim , Alexander Lakhin , Tom Lane , PostgreSQL Hackers , Andres Freund Subject: Re: Remove dependence on integer wrapping Message-ID: References: <875ad3ec-f216-487e-baad-cdbaf32c1fcf@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Aug 15, 2024 at 10:49:46PM -0400, Joseph Koshakow wrote: > This updated version LGTM, I agree it's a good use of pg_abs_s32(). Committed. -- nathan