Date: Wed, 14 Aug 2024 14:38:59 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: jian he <jian.universality@gmail.com>,
	Joseph Koshakow <koshy44@gmail.com>,
	Matthew Kim <matthewkmkim@gmail.com>,
	Alexander Lakhin <exclusion@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Andres Freund <andres@anarazel.de>
Subject: Re: Remove dependence on integer wrapping
Message-ID: <Zr0H04P1XBjgbyVg@nathan>
References: 
 <CAAvxfHckS2181hMcr+N2HehUa-HuN-fyJV3WGfth=8tSZGQb-g@mail.gmail.com>
 <CAGzNdfF-nbL=-2vP=pCynn0-2kwTt3wW96dctdJYveeOWrvY1A@mail.gmail.com>
 <CACJufxHNwqoXoP91a-2D3NytrurTSK_+-hd+XeVCYAbk2F0Uhw@mail.gmail.com>
 <CAAvxfHfuxiMG4_YB5oBmJtK7mQx6FRKcUhNueXGwKT6_r=4W_Q@mail.gmail.com>
 <CACJufxFUKTQx8wUpxtRPT31D+a7fNxAL_A_-S4XaR-oZkKEgxA@mail.gmail.com>
 <ZrvUOkL19KHEH2sb@nathan>
 <ZrwfgNyDXy99NUOS@nathan>
 <875ad3ec-f216-487e-baad-cdbaf32c1fcf@iki.fi>
 <ZrznaJTIOPgSjEJ7@nathan>
 <d33f2c31-1fcf-44be-8a39-686c524a389c@iki.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d33f2c31-1fcf-44be-8a39-686c524a389c@iki.fi>
Archived-At: <https://www.postgresql.org/message-id/Zr0H04P1XBjgbyVg%40nathan>
Precedence: bulk

On Wed, Aug 14, 2024 at 10:29:39PM +0300, Heikki Linnakangas wrote:
> Hmm, that still doesn't say what operation it's referring to. They existing
> comments say "a + b", "a - b" or "a * b", but this one isn't referring to
> anything at all. IMHO the existing comments are not too clear on that either
> though. How about something like this:

Yeah, this crossed my mind, too.  I suppose now is as good a time as any to
improve it.  Your suggestion looks good to me, so I will modify the patch
accordingly before committing.

-- 
nathan