Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sb9Af-00EK6C-CY for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Aug 2024 01:39:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sb9Ad-00GPyR-FD for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Aug 2024 01:39:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sb9Ac-00GPyF-1P for pgsql-hackers@lists.postgresql.org; Tue, 06 Aug 2024 01:39:27 +0000 Received: from fhigh7-smtp.messagingengine.com ([103.168.172.158]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sb9AV-003NtO-8q for pgsql-hackers@lists.postgresql.org; Tue, 06 Aug 2024 01:39:25 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 4005B1150836; Mon, 5 Aug 2024 21:39:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 05 Aug 2024 21:39:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1722908357; x=1722994757; bh=V39WkHJSBG grEzsXFZuiBMkiAUEm5IHMcmGKoQuIaBY=; b=kZg+g4HlywmBVbH3qUGcfwofIl VI5f1gxiCPujGCGSHGkYjqKCa0/KIin9WDEDiUgNvsD6kvvCZ3n8KCvWVoI1wTlP YxRCYBgxnN9xzMilmNtZmkpIVBZQMKekaQdU7XngyQaFgn7bKY1i4XR8ukRBOMI8 HicUEHuGMzVeLY8pI1/K5mFwJ3yOEFvGhYKzIvm8Z3osTHONamMN+zBamI4LmtqC uTrTqT9khZk2cAXJGFfSpnKCOgMxM2PEz2XR5lwzv9JWVWKbLrUmBBKBqHLJYZj1 Rg9uqiNBcYiO4xza8EcgxTYRPS1mI242/97dYOqBhM7ILvLUiUionq9bLL9A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1722908357; x=1722994757; bh=V39WkHJSBGgrEzsXFZuiBMkiAUEm 5IHMcmGKoQuIaBY=; b=jBn6AT+GFdmLE1IhGwAuCL/FRyQ5zRz0ktO2VvmB1g36 ohwfG05inXRXpJJjARY+i3tEWWsKq1AV96fpDlujUbkQwW8mOfC0sK4hxHL508iU t9ImkhT/DGI6vfkBu6HZxtW6GFl8VhSqmlAQRX9tY9bjjhLlcEMI7iBjlH7ON0Tn GHzsLpVDy5sJrq8c7hO/ur0xsLsuExgcpo8ws20HTK7nNw9PjGcIUc+QSILosRKs rggU/Gn5uZhi6eg5NGP3G22/MMJoy8EcNWZdP73FzZdtck9UBnuVGhMir1jwwgXp NO+ZPWI3kyhRIYI5YOvav/x7a0VE/xwxUKq4YG2dKw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrkeejgdehudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecufghrlhcuvffnffculdejtddmnecujfgurhepfffhvf evuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcurfgrqhhu ihgvrhcuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqeenucggtffrrghtthgvrh hnpeetleeifedufffhhfdtteelgeeggeffhfekueevteeigfduudevudetgfegiedvjeen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthh grvghlsehprghquhhivghrrdighiiipdhnsggprhgtphhtthhopedt X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 5 Aug 2024 21:39:15 -0400 (EDT) Date: Tue, 6 Aug 2024 10:39:10 +0900 From: Michael Paquier To: Kyotaro Horiguchi Cc: pgsql-hackers@lists.postgresql.org Subject: Re: Missing reflection in nls.mk from recent basebackup changes Message-ID: References: <20240806.102123.648178476296575604.horikyota.ntt@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NrAtzoUSj/+wF38C" Content-Disposition: inline In-Reply-To: <20240806.102123.648178476296575604.horikyota.ntt@gmail.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --NrAtzoUSj/+wF38C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 06, 2024 at 10:21:23AM +0900, Kyotaro Horiguchi wrote: > After a recent commit f80b09bac8, make update-po fails with "missing > required files". The commit moved some files to fe_utils but this > change was not reflected in pg_basebackup's nls.mk. The attached patch > fixes this issue. You are right. Still, it is not something that committers are required to update when introducing new files, isn't it? I don't see why we should be aggressive here for HEAD. ad8877cb5137 has done a large batch of these for the v17 cycle. -- Michael --NrAtzoUSj/+wF38C Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmaxfr4ACgkQnvQgOdby QH3RIg//ZYBVLhl367sbouZ19h7q7Sxud6TTttg7eff+0jOR51opSYmKyHymYPtD V9WsIzEcKFrGmVH1OmAcLVytBGcLh+EXN6cx9zcdN+RheiUYdMJEnHRGXfmFq2hM mx3yjX8OPZuRVbWsi4hzPJt0nuZDWMOorfyZj3sPn5rUpIbtWUgiqks77C7YBQZN 6llhHQjCAig0P9Zbd1R5J8M2c+ev+UdMSxCNg9nC1bv4RE0vZ+ybZZSkBYf6N1em wXW4MaXpy7plJI7NF8dnCKrgLZXuQNrALiTCJqSi+rtIdACHZ6KzKCbTzF0g/yns b4pQo1ydjIAKYPG11ZF4NM9Uq+a8bxhHi+svZ8Me3rEewaDmZiG/o8S5IffRJqb0 NTl8Jt9Fkwy9CJ3UmABLgmvTFJJ5/WSmpSj+wKmQPIN1xmnbrtfoBWieQVkcbi1b zWxy2LBFpmc5y9cXHPa0F5B456iFyJe7QZircScXr5/ZkydOpmIJv2IITw2UQInk yb+RgTk9pr1vbLZLTa++UcrtMzDNADYpxvhKGxnWWFV5XRc3uUBab35SP0qifpC5 Zq6+3CXd/bgJ0x+o6pT/ttC/Wj4A2zAROPXUQcFqAWE56QI6qwYDA4CqrF585Wqv /uGxacGHhb3yhNZ2Qi68BDr96TBfEjX6NRk9ABui/M1nh+4TgEs= =ERVV -----END PGP SIGNATURE----- --NrAtzoUSj/+wF38C--