Date: Wed, 7 Aug 2024 09:36:59 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Sami Imseih <samimseih@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Robert Haas <robertmhaas@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Restart pg_usleep when interrupted
Message-ID: <ZrOGi8RZTSHxTq9W@nathan>
References: <ZpVaXQGEspp3gk8S@nathan>
 <ZpX/5/irF/gZqT7b@ip-10-97-1-34.eu-west-3.compute.internal>
 <CDF34F36-3A52-47C8-B1D3-5D32A34EC3A7@gmail.com>
 <ZqNd7WfTm3sUCpjy@ip-10-97-1-34.eu-west-3.compute.internal>
 <33287B8A-3CA0-494F-87D3-C9D85C6468FE@gmail.com>
 <ZqiIxptiTDqRTxDx@ip-10-97-1-34.eu-west-3.compute.internal>
 <19E276C9-2C2B-435A-B275-8FA22222AEB8@gmail.com>
 <ZrHmE3zUSNXzoHCU@ip-10-97-1-34.eu-west-3.compute.internal>
 <50E1D6AD-3E51-4E45-95A7-7B20DC037DCB@gmail.com>
 <ZrMNlUd1h09nMrNQ@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZrMNlUd1h09nMrNQ@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: <https://www.postgresql.org/message-id/ZrOGi8RZTSHxTq9W%40nathan>
Precedence: bulk

On Wed, Aug 07, 2024 at 06:00:53AM +0000, Bertrand Drouvot wrote:
> +		SleepEx((microsec < 500 ? 1 : (microsec + 500) / 1000), FALSE);

I think this deserves a comment.

> +#define INSTR_TIME_ADD_MICROSEC(x,t) \
> +	((x).ticks += t * NS_PER_US)

I'd add parentheses around "t" to ensure any expressions given as "t" are
evaluated first.

Also, do we need to worry about overflow here?  It looks like the rest of
instr_time.h is oblivious about overflow, so maybe this is better discussed
in a separate thread...

-- 
nathan