Date: Fri, 9 Aug 2024 14:03:55 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Sami Imseih <samimseih@gmail.com>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Restart pg_usleep when interrupted
Message-ID: <ZrZoG3uZmUOgbHOv@nathan>
References: <ZqNd7WfTm3sUCpjy@ip-10-97-1-34.eu-west-3.compute.internal>
 <33287B8A-3CA0-494F-87D3-C9D85C6468FE@gmail.com>
 <ZqiIxptiTDqRTxDx@ip-10-97-1-34.eu-west-3.compute.internal>
 <19E276C9-2C2B-435A-B275-8FA22222AEB8@gmail.com>
 <ZrHmE3zUSNXzoHCU@ip-10-97-1-34.eu-west-3.compute.internal>
 <50E1D6AD-3E51-4E45-95A7-7B20DC037DCB@gmail.com>
 <ZrMNlUd1h09nMrNQ@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZrOGi8RZTSHxTq9W@nathan>
 <D1558DDA-CEED-4CED-B3ED-C425D996FCA3@gmail.com>
 <ZrUkELsJs3CI896W@nathan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZrUkELsJs3CI896W@nathan>
Archived-At: <https://www.postgresql.org/message-id/ZrZoG3uZmUOgbHOv%40nathan>
Precedence: bulk

On Thu, Aug 08, 2024 at 03:01:20PM -0500, Nathan Bossart wrote:
> Thanks.  This one looks pretty good to me, and so I plan to commit it in
> the near future unless anyone voices concerns about the approach.

As I am preparing this for commit, I'm wondering whether it makes sense to
name the new function vacuum_sleep() and keep it private to vacuum.c.
Nothing about this function is terribly specific to vacuum, and it's not
inconceivable that it might be useful elsewhere.  Perhaps we should move it
to pgsleep.c and rename it to something to the effect of
pg_usleep_non_interruptable().

-- 
nathan