Date: Tue, 13 Aug 2024 10:09:57 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: "Imseih (AWS), Sami" <samimseih@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>,
	Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Restart pg_usleep when interrupted
Message-ID: <Zrt3ReA-nB7MJn2q@nathan>
References: <526E6A51-FE30-47C4-85C8-F2D18877607F@gmail.com>
 <ZrmcoWn1q2hQv0QU@ip-10-97-1-34.eu-west-3.compute.internal>
 <AED4B8D0-3ED1-463C-BA9F-BFF4B511315E@gmail.com>
 <BB742B52-D481-4D5A-926A-4ED4A6ADA98B@gmail.com>
 <ZrowomFX5yMV9zUm@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZrpnfTVK-iaIW98I@nathan>
 <e3297b5e-0b33-4f45-afcd-4b00ba0b3547@gmail.com>
 <cb18c6a7-4394-4488-ad71-0b9826c8899c@iki.fi>
 <ZrqG0tIgP2HbGRm1@nathan>
 <2b5ac681-11d5-470d-af40-89ead9a868aa@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2b5ac681-11d5-470d-af40-89ead9a868aa@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Zrt3ReA-nB7MJn2q%40nathan>
Precedence: bulk

On Mon, Aug 12, 2024 at 05:35:08PM -0500, Imseih (AWS), Sami wrote:
>> Skimming the last few messages of that thread [0], it looks like Bertrand
>> is exploring ways to avoid so many interrupts.  I guess the unavoidable
>> question is whether this work is still worthwhile given that improvement.
>
> The way the instrumentation in [0] dealt with interrupts was too complex,
> which is why it seemed better to handle the restart the remainder of the
> sleep in the sleep function

Can you elaborate on how it is too complex?

-- 
nathan