Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 29 Aug 2024 07:48:07 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	Julien Rouhaud <rjuju123@gmail.com>
Subject: Re: query ID goes missing with extended query protocol
Message-ID: <Zs-pJ9dihDE1Nwlw@paquier.xyz>
References: <CA+TgmoZxtnf_jZ=VqBSyaU8hfUkkwoJCJ6ufy4LGpXaunKrjrg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="8meD6zrJK12C0jcH"
Content-Disposition: inline
In-Reply-To: <CA+TgmoZxtnf_jZ=VqBSyaU8hfUkkwoJCJ6ufy4LGpXaunKrjrg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Zs-pJ9dihDE1Nwlw%40paquier.xyz>
Precedence: bulk


--8meD6zrJK12C0jcH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Aug 28, 2024 at 04:27:38PM -0400, Robert Haas wrote:
> - Add a call to
> pgstat_report_query_id(queryDesc->plannedstmt->queryId, false) to the
> top of ExecutorRun() with an appropriate comment.
> - Fix the incorrect comment mentioned above.
> - Back-patch to all releases containing 4f0b0966c86 i.e. v14+.

This is being discussed already on a different thread:
- Thread: https://www.postgresql.org/message-id/CA+427g8DiW3aZ6pOpVgkPbqK97ouBdf18VLiHFesea2jUk3XoQ@mail.gmail.com
- CF entry: https://commitfest.postgresql.org/49/4963/

There is a patch proposed there, that attempts to deal with the two
cases of a portal where ExecutorRun() is called once while holding a
tuplestore and where ExecutorRun() is called multiple times.  A few
approaches have been discussed for the tests, where the new psql
metacommands added in d55322b0da60 should become handy.  That's on my
TODO spreadsheet of things to look at, but I did not come back to it
yet.

A backpatch would be adapted for that, yep.  I'd like to see tests on
HEAD at least.
--
Michael

--8meD6zrJK12C0jcH
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmbPqScACgkQnvQgOdby
QH3TAg//euIPUBItER7WVhulXPQ6Rr39I8Y7AbYZrLVtT/9G2+Z0kscaGzzod/Bt
nWm8bFdx8iHLJEqHr2sw28ZDT5JJo3+SUypsiSa/b5Uv1bvdGZ2WQETTIkfvZKx3
z0dMTOo6UuG0P96f/Mljy2yIF3m58waqmjh7Zu6XWJQ3dvQHuJnRKB7/d3H/r9u8
du76nc8+8CcnYaVQKI/r2DSSSs5ZVYPm63p9tcOCnVeEKp1a3x+FvScAcnBZeso9
d2SQNDI3HqLAtrJ2BAOW7aSkB95waMgcI4EqTV/ZB+lnCsq0dMZcrw8J9hlXC6tH
a0uIn7/bcnTFjsaQnhG4TO0UEuYYyPFdJECgKlvjSuEP49tyjBWQzRR7mniQtmMA
CEHeIGN1xicX8JW0jp3OTaAM80zrUXpmndWOpUtgT19av/S+u8KDWWcrorAzO/1y
sQEh7nqGnAbO1rBoSNmoOT5kdGOd+u0Vx4wuY6c0ExvkygvFyg6veLgrXMBKMPLr
HcnGCJzPo8GJqqmXwzUvUtdak270bfQeznepudvqmhAlKXiHbq9swlNRysEJLLlZ
FVPip0qS93p+QiXutiSBpaOedkkHTYj0zaUCCf0trXyrheshCrnEqGQH6JE17U6I
JiuEA0g0ErkUo22Qs5r0cNdOIStFOK1e55iNTQeCQvFVU+OoCNA=
=GH+w
-----END PGP SIGNATURE-----

--8meD6zrJK12C0jcH--