Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1sjklm-003czs-UF
	for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Aug 2024 19:25:22 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1sjklk-006eI9-9Y
	for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Aug 2024 19:25:20 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <nathandbossart@gmail.com>)
	id 1sjklj-006eI0-Vx
	for pgsql-hackers@lists.postgresql.org; Thu, 29 Aug 2024 19:25:20 +0000
Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.94.2)
	(envelope-from <nathandbossart@gmail.com>)
	id 1sjkld-002823-CX
	for pgsql-hackers@postgresql.org; Thu, 29 Aug 2024 19:25:19 +0000
Received: by mail-io1-xd32.google.com with SMTP id
 ca18e2360f4ac-82521c46feaso46968139f.2
        for <pgsql-hackers@postgresql.org>;
 Thu, 29 Aug 2024 12:25:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1724959513; x=1725564313;
 darn=postgresql.org;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=Db9H5cYBHr1T9+MMg3MCQfgMUP4Jlbj7kWeLsvL+9N0=;
        b=Q1ZlHCWvM3dR/9wofwqYk1aohR2no/oY5Yr2DzPLrABJ7Lkf2XCG3T3TOp5Su6TVBH
         ZaX8sXbagvXdG2jgUHzPH/BQ7Tp+LbU+Y1NDwrOMphDxxPi36vl4aGT0fFBep7oCyjoG
         Ajf35Rmqpp4MBstA/wbTPLBrHUrYn8ico1V82OZ+GatO9uzFFNQclmdvJA3in5eVomrp
         73llWMKfwepn8Sqw0Z0lnHhPLdWVOX5fv/peDy96yTMqvfUdcMmlA46/5C4jh4G7OzeF
         QM0ycsMXgZAfeB9FXkDJHi/5WxaYgpcSv9WoNa3hHIKUtoQPl7zTNMlwnRSiLkBHLVal
         fOcw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1724959513; x=1725564313;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=Db9H5cYBHr1T9+MMg3MCQfgMUP4Jlbj7kWeLsvL+9N0=;
        b=uiukVK8hlwIjlKnoC8Jpp1PxsnpTio5UZ5sSffgkZWs1/kh2DPD6lm5sh9IGiwjfhh
         5NjKI7vGbn/nnHOt6votJR9MhNZHmPx8qv2YxA0YQkQ6Yt34/Zjtr8tk+OZF+6Ec+7mn
         21gAOtpASkIO+dxzNL57TWJ0n0dWs7100O8PN4bx+/UJrlRDbfQd3Fbltj1uO1oM2bJd
         SZwIT4NEWvX9jFvcM5MS+upDkcjUzs2OqbDvosffcd57JgCHa5plxECmcMEl8NHUh6hq
         gSe4MIZ/FfCJ8mn38zaaRrHGJGZKR0HsVTckaln4QcRm21h4HKeLsMOtjbphr8Nv5meE
         jUXA==
X-Forwarded-Encrypted: i=1;
 AJvYcCVa9umAakhYAqxlAL2aQibGAPswRRvNB53O9DrOEhVCfbrn/ClAqLrmk2fPzUfEyusNKiDOcmAvjoXYJecR@postgresql.org
X-Gm-Message-State: AOJu0Ywxmj4BuVBrywdKKPcQk5Fjli+KMn24BxQk9SLna65M+eh2QVtd
	1BEWxersceYkLpDzIF/QvJEU+gZaEugEA+IaVTY0bkaCv69ZdHo2tYMMOQ==
X-Google-Smtp-Source: 
 AGHT+IEzB7JNrMN0wa6oXRs1SU5t3+j8Jkez2AGbT603ntT0liJ55+w7SU4SWIpfF506oSY18ZXoTQ==
X-Received: by 2002:a05:6602:1692:b0:81f:958d:f575 with SMTP id
 ca18e2360f4ac-82a1108d3c7mr545683039f.14.1724959512948;
        Thu, 29 Aug 2024 12:25:12 -0700 (PDT)
Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net.
 [162.195.168.172])
        by smtp.gmail.com with ESMTPSA id
 ca18e2360f4ac-82a1a5cbb5esm46554839f.50.2024.08.29.12.25.12
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 29 Aug 2024 12:25:12 -0700 (PDT)
Date: Thu, 29 Aug 2024 14:25:11 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Ayush Vatsa <ayushvatsa1810@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
	michael@paquier.xyz
Subject: Re: Pgstattuple on Sequences: Seeking Community Feedback on
 Potential Patch
Message-ID: <ZtDLF9dPJeJmt9AB@nathan>
References: 
 <CACX+KaP3i+i9tdPLjF5JCHVv93xobEdcd_eB+638VDvZ3i=cQA@mail.gmail.com>
 <Zsy6w_yW2QKYSo_m@nathan>
 <CA+TgmoYm0X=KuHry1A6prNzf3pUmAcXYgQEr25kCY8jSMJaVjg@mail.gmail.com>
 <ZszGBMK1D4hCsRnD@nathan>
 <CACX+KaNhg-ZwkqCSjsq7j_gRYDmHip2b4kwa6ohac0MspSeW9w@mail.gmail.com>
 <ZtCxo95K_bqGbmNQ@nathan>
 <ZtCyGRmho3GJ3fHI@nathan>
 <CACX+KaM3Kk-mEUm4E_iLa5AXGKnhAa5QT6odPDRFeSeadr27ag@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CACX+KaM3Kk-mEUm4E_iLa5AXGKnhAa5QT6odPDRFeSeadr27ag@mail.gmail.com>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/ZtDLF9dPJeJmt9AB%40nathan>
Precedence: bulk

On Fri, Aug 30, 2024 at 12:17:47AM +0530, Ayush Vatsa wrote:
> The patch with all the changes is attached.

Looks generally reasonable to me.

-- 
nathan