Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1slHKH-006T5Y-GI for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Sep 2024 00:23:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1slHKF-004i1l-RC for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Sep 2024 00:23:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1slHKE-004i1O-Az for pgsql-hackers@lists.postgresql.org; Tue, 03 Sep 2024 00:23:15 +0000 Received: from fout5-smtp.messagingengine.com ([103.168.172.148]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1slHKB-000N4K-5G for pgsql-hackers@lists.postgresql.org; Tue, 03 Sep 2024 00:23:13 +0000 Received: from phl-compute-03.internal (phl-compute-03.nyi.internal [10.202.2.43]) by mailfout.nyi.internal (Postfix) with ESMTP id ED5E213801E7; Mon, 2 Sep 2024 20:23:09 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Mon, 02 Sep 2024 20:23:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1725322989; x=1725409389; bh=WXr4TO6QuD MBMS52f4dCtrB90uAdDg8CPIDlOlXcZaU=; b=hhXB+5qxdKkyE5SJSK63ZLU24E agw/7Y2/M972g0HsOoEX8PyXb+Mc8pRRUy1+O95ZaZonTyG8Mldi+0+9tfPJCFh+ mU389VF5DIL+soigaplmU2zlxTAdJYIZpB9HWSRAglmSiIz/D1Raq7vz1qYbl4kj heAxGNKTA0zGZ3CveikoCYRsEOBXMwZ/pbC6oyO6TUzpxD2THP58GH3bfQQ1XozH 5OE8Ut4RZxXp7J6OaOWy3IaDYmgoD8/GW5b8Gx0Fn9v7SxkYqxXxJ+9fPj7NcOpi BWhNRLFDrT2l+xa6T4iTaHZ/tw90a44S4jmiTSCC7xTcVLcBW1tZFFPzB3mQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1725322989; x=1725409389; bh=WXr4TO6QuDMBMS52f4dCtrB90uAd Dg8CPIDlOlXcZaU=; b=IuztgSqNlJc6zgE5F685eLlpbJ3MDE57B8QfynldRszw 0WRmkHur5KjI9fZrrNE1nkt7wv2t6axoH40O/n3rCnT7ywEgrwZNi1l7o1FPdKL2 wEr+uxrHHoVPziBAc4RDUoJ8ynb6+mpJdlgipy+IdS5aAu+hro7xT7L28OSxpov2 W5w6kbkBNSGwfXCdMeVds51S3sBpOKSJXNW7AKKTpWJDcdpbkKasvVWlMSbTW0Do zv4mVK6TP4HryErFh5QFR0I1WnKLL2QrLeoN0YvMR3a5a4GGVT4iXRLGm1OYcZN+ 4xriXjFtcw4ssELErCZS+0vpDcqOJfu3Jf2lLdGq0Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudehgedgfeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnegfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhf gggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruc eomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteel ieefudffhffhtdetleeggeegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhes phgrqhhuihgvrhdrgiihiidpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouh htpdhrtghpthhtohepnhgrthhhrghnuggsohhsshgrrhhtsehgmhgrihhlrdgtohhmpdhr tghpthhtohepuggrvhhiugdrghdrjhhohhhnshhtohhnsehgmhgrihhlrdgtohhmpdhrtg hpthhtohepphhgshhqlhdqhhgrtghkvghrsheslhhishhtshdrphhoshhtghhrvghsqhhl rdhorhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 2 Sep 2024 20:23:08 -0400 (EDT) Date: Tue, 3 Sep 2024 09:22:58 +0900 From: Michael Paquier To: Nathan Bossart Cc: "David G. Johnston" , Postgres hackers Subject: Re: Partitioned tables and [un]loggedness Message-ID: References: <20240424202640.GB861150@nathanxps13> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EN+cX2H9xY5+JqwU" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --EN+cX2H9xY5+JqwU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 29, 2024 at 09:49:44AM -0500, Nathan Bossart wrote: > IMHO continuing to allow partitioned tables to be marked UNLOGGED just > preserves the illusion that it does something. An ERROR could help dispel > that misconception. Okay. This is going to be disruptive if we do nothing about pg_dump, unfortunately. How about tweaking dumpTableSchema() so as we'd never issue UNLOGGED for a partitioned table? We could filter that out as there is tbinfo->relkind. -- Michael --EN+cX2H9xY5+JqwU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmbWVuIACgkQnvQgOdby QH2SOQ//QiEv8bYQiqohNPOrmgIvI1DPTpP6lxG1fhBGBo8YmC3WdfOPd1LC22KY 47yxSM+Ge1B7ZzH+ybNfN+mxygjfb84Iul2b9qi83vG7Bvld28lfEDkomWuEBDLz Ly88cyzu7bGhCltcCJ1xjN/29rc/t3sJHzZV1+R66Cz5R7M+Ik8aAEo6C4Jiwj4D YFss7FfKozmw6IPIjxvHHtPoR1wmcP6l7CSlRa5EkACvBx9mrPpSnzYqI94A341f qXt566z94vl0hYCMt/LTsQf29TnhTeOHKkQL0xr2fpoONB6cE3JXMS5rvYCql951 c+qI5HVgC9R3JmfVoNGc1//yhZyfud+Gc3CaC/SRyDP4pWpH5KyH3t7/PCqoHzTM lxb7Tej5/9vcaYw8EXXP5aKCQ/kH+bJtLCRAKT2lvq8pbycTVEIRxsAk/ug8fGb8 cCw48/kYHJ/ox3Z2WuWTAjglh4ztiS9dzyKjQqF/pcQZVxhHYD0Z1wwiwjzKtp7n 8j93yDtBRtm4dDcNEZ7wfwnFV77uMDBCdI8bdrKXSTJ23tyqCcGr72PwQUSvkJng nNhrW3HGE2OY8yIJ4G4ligj8IqixP5aQ0yLTJC6Xsy2raw1IynrnccjVD5cihwdp yCOmI1fM2CwRvKEiLDRNtQMDMNATNV6ODLfkW3ohM8Jo+djvydQ= =KFAU -----END PGP SIGNATURE----- --EN+cX2H9xY5+JqwU--